Paths

Table of Contentst

Differential D16238

Fix ApplicationSearch URIs for Settings
ClosedPublic
Actions

Authored by epriestley on Jul 5 2016, 11:45 PM.

Details

Reviewers

chad

Maniphest Tasks

T11275: Missing "Edit Queries..." and "Advanced Search" pages in User Settings

Commits

rP989b585bbe58: Fix ApplicationSearch URIs for Settings

Summary

Fixes T11275. This search query doesn't actually have any options so these links are a little pointless, but generate valid links instead of 404s.

Test Plan

Clicked "Advanced Search" and "Edit Queries" from /settings/.

Diff Detail

Repository

rP Phabricator

Branch

setting1

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 12935
Build 16508: Run Core Tests
Build 16507: arc lint + arc unit

Event Timeline

epriestley updated this revision to Diff 39056.Jul 5 2016, 11:45 PM

epriestley retitled this revision from to Fix ApplicationSearch URIs for Settings.

epriestley updated this object.

epriestley edited the test plan for this revision. (Show Details)

epriestley added a reviewer: chad.

epriestley added a task: T11275: Missing "Edit Queries..." and "Advanced Search" pages in User Settings.

chad accepted this revision.Jul 5 2016, 11:55 PM

chad edited edge metadata.

This revision is now accepted and ready to land.Jul 5 2016, 11:55 PM

Closed by commit rP989b585bbe58: Fix ApplicationSearch URIs for Settings (authored by epriestley, committed by epriestley). · Explain WhyJul 5 2016, 11:55 PM

This revision was automatically updated to reflect the committed changes.

epriestley mentioned this in T11296: Edit Queries/Advanced Search 404s from Settings page.Jul 8 2016, 11:53 AM

Revision Contents
Changeset List

Path

Size

src/

applications/

settings/

query/

PhabricatorUserPreferencesSearchEngine.php

2 lines

Diff 39056

View Options

src/applications/settings/query/PhabricatorUserPreferencesSearchEngine.php

Fix ApplicationSearch URIs for SettingsClosedPublicActions