Page MenuHomePhabricator

Inch toward using ApplicationSearch to power related objects
ClosedPublic

Authored by epriestley on Jun 28 2016, 11:16 PM.
Tags
None
Referenced Files
F17914139: D16189.id38944.diff
Tue, Jul 29, 6:55 PM
F17830815: D16189.id38955.diff
Sat, Jul 26, 11:25 AM
F17828805: D16189.id38944.diff
Sat, Jul 26, 9:34 AM
F17812401: D16189.diff
Fri, Jul 25, 7:25 PM
F17674469: D16189.id38955.diff
Sun, Jul 13, 7:18 AM
Unknown Object (File)
Tue, Jul 1, 7:23 PM
Unknown Object (File)
Jun 30 2025, 2:23 PM
Unknown Object (File)
Jun 29 2025, 7:30 PM
Subscribers
None

Details

Summary

Ref T4788. Fixes T9232. This moves the "search for stuff to attach to this object" flow away from hard-coding and legacy constants and toward something more modular and flexible.

It also adds an "Edit Commits..." action to Maniphest, resolving T9232. The behavior of the search for commits isn't great right now, but it will improve once these use real ApplicationSearch.

Test Plan

Edited a tasks' related commits, mocks, tasks, etc.

Diff Detail

Repository
rP Phabricator
Branch
attach1
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 12823
Build 16336: Run Core Tests
Build 16335: arc lint + arc unit

Event Timeline

epriestley retitled this revision from to Inch toward using ApplicationSearch to power related objects.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
chad edited edge metadata.
This revision is now accepted and ready to land.Jun 29 2016, 12:44 AM
This revision was automatically updated to reflect the committed changes.