HomePhabricator

Provide a missing timeout on the non-cluster connection pathway

Description

Provide a missing timeout on the non-cluster connection pathway

Summary:
Ref T11232. The cluster connection pathway specifies a timeout when connecting, but this connection pathway does not. (I'm not sure if we just never did or if it got lost at some point.)

Soon, T11044 will obsolete this and unify the database connection pathways, but that's a more complicated change.

I'm not sure if this will fix T11232, but it can't hurt.

Test Plan: Put a throw on timeout specifications. Before the change: did not hit it in non-cluster configurations. After the change: hit it.

Reviewers: chad

Reviewed By: chad

Maniphest Tasks: T11232

Differential Revision: https://secure.phabricator.com/D16194

Details

Provenance
epriestleyAuthored on Jun 29 2016, 6:15 PM
epriestleyPushed on Jun 29 2016, 6:20 PM
Reviewer
chad
Differential Revision
D16194: Provide a missing timeout on the non-cluster connection pathway
Parents
rP2b76785a13df: Better 404 for Phame
Branches
Unknown
Tags
Unknown
Tasks
T11232: MySQL connection may not respect timeout?
Build Status
Buildable 12831
Build 16347: Run Core Tests