Page MenuHomePhabricator
Differential D16168

Add space under comment previews
ClosedPublic
Actions

Authored by chad on Jun 22 2016, 7:15 PM.
Tags
None
Referenced Files
Unknown Object (File)
Mon, Apr 29, 5:09 PM
Unknown Object (File)
Sun, Apr 28, 7:28 PM
Unknown Object (File)
Thu, Apr 25, 3:04 AM
Unknown Object (File)
Sat, Apr 20, 3:23 PM
Unknown Object (File)
Mon, Apr 15, 5:47 AM
Unknown Object (File)
Sun, Apr 14, 9:13 PM
Unknown Object (File)
Wed, Apr 10, 7:22 PM
Unknown Object (File)
Mon, Apr 8, 4:14 PM
View All Files
Subscribers
Korvin

Details

Reviewers
epriestley
Maniphest Tasks
T11166: When an install has no footer, Maniphest task previews have no bottom margin
Commits
rP3bb3170a2c7c: Add space under comment previews
Summary

Fixes T11166. Adds some class, and space to the preview widget.

Test Plan

Test Maniphest, Ponder, etc, without a footer.

Diff Detail

Repository
rP Phabricator
Branch
comment-view (branched from master)
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 12774
Build 16260: Run Core Tests
Build 16259: arc lint + arc unit

Event Timeline

chad updated this revision to Diff 38893.Jun 22 2016, 7:15 PM
chad retitled this revision from to Add space under comment previews.
chad updated this object.
chad edited the test plan for this revision. (Show Details)
chad added a reviewer: epriestley.
chad added a task: T11166: When an install has no footer, Maniphest task previews have no bottom margin.
Herald added a subscriber: Korvin. · View Herald TranscriptJun 22 2016, 7:15 PM
epriestley accepted this revision.Jun 22 2016, 7:15 PM
epriestley edited edge metadata.
This revision is now accepted and ready to land.Jun 22 2016, 7:15 PM
Closed by commit rP3bb3170a2c7c: Add space under comment previews (authored by chad, committed by chad). · Explain WhyJun 22 2016, 7:17 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
resources/
celerity/
6 lines
src/
applications/
transactions/
view/
1 line
webroot/
rsrc/
css/
phui/
4 lines

Diff 38893

View Options

resources/celerity/map.php

Loading...
View Options

src/applications/transactions/view/PhabricatorApplicationTransactionCommentView.php

Loading...
View Options

webroot/rsrc/css/phui/phui-timeline-view.css

Loading...
Phabricator · Built by Phacility