Differential D16157

Fold task-relationship actions into an accordion dropdown
ClosedPublic
Actions

Authored by epriestley on Jun 21 2016, 1:56 AM.

Tags

None

Referenced Files

	F18094069: D16157.id.diff
	Thu, Aug 7, 9:56 PM

	F18081898: D16157.id38870.diff
	Tue, Aug 5, 2:48 AM

	F17948384: D16157.id.diff
	Thu, Jul 31, 8:56 PM

	F17927408: D16157.diff
	Wed, Jul 30, 2:33 PM

	F17836543: D16157.id.diff
	Sat, Jul 26, 4:15 PM

	F17808708: D16157.diff
	Fri, Jul 25, 4:12 PM

	F17772265: D16157.id38870.diff
	Wed, Jul 23, 2:23 PM

	F17748755: D16157.diff
	Tue, Jul 22, 12:25 AM

Subscribers

None

Details

Reviewers

Maniphest Tasks

T11179: Figure out what to do with "Edit Blocking Tasks", "Edit Differential Revisions" and "Edit Pholio Mocks"

Commits

rP56d3197fe0da: Fold task-relationship actions into an accordion dropdown

Summary

Ref T11179. Alternative to D16152. I think this turned out a bit better than the other one did.

Currently, we render two copies of the menu (one for mobile, one for desktop). A big chunk of this is sharing the nodes instead: when you open the mobile dropdown menu, it steals the nodes from the document. When you close it, it puts them back. Magic! Sneaky!

Test Plan

Screen Shot 2016-06-20 at 6.55.27 PM.png (249×354 px, 22 KB)

Screen Shot 2016-06-20 at 6.55.33 PM.png (246×319 px, 23 KB)

Diff Detail

Repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

epriestley updated this revision to Diff 38868.Jun 21 2016, 1:56 AM

epriestley retitled this revision from to Fold task-relationship actions into an accordion dropdown.

epriestley updated this object.

epriestley edited the test plan for this revision. (Show Details)

epriestley added a reviewer: chad.

epriestley added a task: T11179: Figure out what to do with "Edit Blocking Tasks", "Edit Differential Revisions" and "Edit Pholio Mocks".

Herald edited edge metadata. · View Herald TranscriptJun 21 2016, 1:56 AM

epriestley mentioned this in D16152: Combine task-relationship actions into a dropdown menu.Jun 21 2016, 2:12 AM

chad accepted this revision.Jun 21 2016, 2:13 AM

chad edited edge metadata.

This revision is now accepted and ready to land.Jun 21 2016, 2:13 AM

Closed by commit rP56d3197fe0da: Fold task-relationship actions into an accordion dropdown (authored by epriestley, committed by epriestley). · Explain WhyJun 21 2016, 2:14 AM

This revision was automatically updated to reflect the committed changes.

chad added inline comments.Jun 21 2016, 3:18 AM

webroot/rsrc/css/phui/phui-button.css
289–300	was this for me to fiddle with or is this your current favorite?

:) :) :) :) :) :) :) :)

Feel free to reduce it to something more tasteful.

epriestley mentioned this in D17210: Hide dropdown menus when users click workflow items.Jan 16 2017, 9:33 PM

epriestley mentioned this in rPa4a948561283: Hide dropdown menus when users click workflow items.Jan 16 2017, 9:38 PM

Revision Contents
Changeset List

Path

Size

resources/

celerity/

49 lines

src/

applications/

base/

controller/

PhabricatorController.php

5 lines

maniphest/

controller/

ManiphestTaskDetailController.php

50 lines

view/

layout/

PhabricatorActionListView.php

13 lines

PhabricatorActionView.php

110 lines

phui/

PHUIButtonView.php

12 lines

PHUIHeaderView.php

18 lines

PHUITimelineEventView.php

4 lines

PHUITwoColumnView.php

2 lines

webroot/

rsrc/

css/

phui/

phui-button.css

36 lines

js/

phui/

behavior-phui-dropdown-menu.js

29 lines

behavior-phui-submenu.js

44 lines

phuix/

PHUIXDropdownMenu.js

4 lines

Diff 38870

resources/celerity/map.php

Loading...

src/applications/base/controller/PhabricatorController.php

Loading...

src/applications/maniphest/controller/ManiphestTaskDetailController.php

Loading...

src/view/layout/PhabricatorActionListView.php

Loading...

src/view/layout/PhabricatorActionView.php

Loading...

src/view/phui/PHUIButtonView.php

Loading...

src/view/phui/PHUIHeaderView.php

Loading...

src/view/phui/PHUITimelineEventView.php

Loading...

src/view/phui/PHUITwoColumnView.php

Loading...

webroot/rsrc/css/phui/phui-button.css

Loading...

webroot/rsrc/js/phui/behavior-phui-dropdown-menu.js

Loading...

webroot/rsrc/js/phui/behavior-phui-submenu.js

Loading...

webroot/rsrc/js/phuix/PHUIXDropdownMenu.js

Loading...