Page MenuHomePhabricator

Fold task-relationship actions into an accordion dropdown
ClosedPublic

Authored by epriestley on Jun 21 2016, 1:56 AM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, May 30, 1:23 AM
Unknown Object (File)
Wed, May 28, 10:30 AM
Unknown Object (File)
Tue, May 27, 8:19 PM
Unknown Object (File)
Tue, May 27, 11:16 AM
Unknown Object (File)
Mon, May 26, 1:59 PM
Unknown Object (File)
Mon, May 19, 7:47 PM
Unknown Object (File)
Sat, May 10, 8:33 AM
Unknown Object (File)
Fri, May 9, 5:35 PM
Subscribers
None

Details

Summary

Ref T11179. Alternative to D16152. I think this turned out a bit better than the other one did.

Currently, we render two copies of the menu (one for mobile, one for desktop). A big chunk of this is sharing the nodes instead: when you open the mobile dropdown menu, it steals the nodes from the document. When you close it, it puts them back. Magic! Sneaky!

Test Plan

Screen Shot 2016-06-20 at 6.55.27 PM.png (249×354 px, 22 KB)

Screen Shot 2016-06-20 at 6.55.33 PM.png (246×319 px, 23 KB)

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

epriestley retitled this revision from to Fold task-relationship actions into an accordion dropdown.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
chad edited edge metadata.
This revision is now accepted and ready to land.Jun 21 2016, 2:13 AM
This revision was automatically updated to reflect the committed changes.
webroot/rsrc/css/phui/phui-button.css
289–300

was this for me to fiddle with or is this your current favorite?

Feel free to reduce it to something more tasteful.