Page MenuHomePhabricator

Combine task-relationship actions into a dropdown menu
AbandonedPublic

Authored by epriestley on Jun 20 2016, 7:36 PM.
Tags
None
Referenced Files
F14962541: D16152.diff
Sun, Feb 16, 7:01 AM
Unknown Object (File)
Mon, Feb 10, 9:30 AM
Unknown Object (File)
Sun, Feb 9, 1:51 AM
Unknown Object (File)
Sun, Feb 9, 1:51 AM
Unknown Object (File)
Fri, Jan 24, 2:12 PM
Unknown Object (File)
Fri, Jan 24, 2:12 PM
Unknown Object (File)
Tue, Jan 21, 8:19 PM
Unknown Object (File)
Jan 6 2025, 11:18 PM
Subscribers
None

Details

Summary

Ref T11179. This combines "Edit Blocking Tasks", "Create Subtask", and "Merge Duplicates In" into a single menu.

Most of this is about trying to make the dropdown look/feel OK and work alright on mobile. It doesn't feel perfect to me, but feels reasonable.

Test Plan

Screen Shot 2016-06-20 at 12.34.00 PM.png (1×616 px, 194 KB)

Screen Shot 2016-06-20 at 12.33.56 PM.png (1×616 px, 207 KB)

Screen Shot 2016-06-20 at 12.33.49 PM.png (1×1 px, 264 KB)

Screen Shot 2016-06-20 at 12.33.41 PM.png (1×1 px, 254 KB)

Diff Detail

Repository
rP Phabricator
Branch
dropdown2
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 12739
Build 16205: Run Core Tests
Build 16204: arc lint + arc unit

Event Timeline

epriestley retitled this revision from to Combine task-relationship actions into a dropdown menu.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.

Those screenshots are in reverse order I guess.

Mobile interaction is that the first menu is just completely replaced by the second menu. Ideally there would probably be some kind of fancy animation or something, but I think the behavior is relatively reasonable overall.

What do you think of just accordian-ing down the list instead of a new popup?

Which do you prefer, I assume this?

chad edited edge metadata.
This revision is now accepted and ready to land.Jun 20 2016, 7:55 PM

Let me try that again, I don't love this particularly.

D16157 feels like the better way forward to me.