Page MenuHomePhabricator

Have modular transactions fall back correctly when selecting feed titles
ClosedPublic

Authored by epriestley on Jun 14 2016, 5:58 PM.

Details

Summary

Ref T9789. Falling back to parent:: is better, and fixes older-style feed stories for Pastes, like "added a comment".

Test Plan

Viewed a comment feed story about a paste.

Diff Detail

Repository
rP Phabricator
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

epriestley updated this revision to Diff 38773.Jun 14 2016, 5:58 PM
epriestley retitled this revision from to Have modular transactions fall back correctly when selecting feed titles.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
chad accepted this revision.Jun 14 2016, 6:03 PM
chad edited edge metadata.
This revision is now accepted and ready to land.Jun 14 2016, 6:03 PM

(Looking at that test failure...)

Hrrrm, doesn't reproduce locally.

Also didn't reproduce when I restarted the build. v. spooooooky

This revision was automatically updated to reflect the committed changes.