Add a "summary" prose diff mode which omits unchanged text
ClosedPublic
Actions

Authored by epriestley on Jun 10 2016, 3:13 PM.

Details

Reviewers

Maniphest Tasks

T7643: Improve prose diffs (was: description changes don't generate usable diffs)

Commits

rPHUad458fb7df59: (stable) Promote 2016 Week 24
rPHU87fa686beecd: (stable) Promote 2016 Week 23
rPHU7233ff63f821: Add a "summary" prose diff mode which omits unchanged text

Summary

Ref T7643. When a user edits a large wiki page, we currently show the entire page in the diff.

Provide a mode where we summarize unchanged text. This tries to just remove the middle section of big "=" changes that have multiple lines/paragraphs.

Test Plan

Unit tests.

Diff Detail

Repository

rPHU libphutil

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

epriestley updated this revision to Diff 38728.Jun 10 2016, 3:13 PM

epriestley retitled this revision from to Add a "summary" prose diff mode which omits unchanged text.

epriestley updated this object.

epriestley edited the test plan for this revision. (Show Details)

epriestley added a reviewer: chad.

epriestley added a task: T7643: Improve prose diffs (was: description changes don't generate usable diffs).

chad accepted this revision.Jun 10 2016, 4:25 PM

chad edited edge metadata.

This revision is now accepted and ready to land.Jun 10 2016, 4:25 PM

Closed by commit rPHU7233ff63f821: Add a "summary" prose diff mode which omits unchanged text (authored by epriestley, committed by epriestley). · Explain WhyJun 10 2016, 4:40 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

utils/

PhutilProseDiff.php

85 lines

__tests__/

PhutilProseDiffTestCase.php

74 lines

Diff 38730

View Options

src/utils/PhutilProseDiff.php

View Options

src/utils/tests/PhutilProseDiffTestCase.php

Add a "summary" prose diff mode which omits unchanged textClosedPublicActions