Page MenuHomePhabricator
Differential D16097

Add a "summary" prose diff mode which omits unchanged text
ClosedPublic
Actions

Authored by epriestley on Jun 10 2016, 3:13 PM.
Tags
None
Referenced Files
F13059833: D16097.diff
Fri, Apr 19, 4:53 PM
Unknown Object (File)
Fri, Apr 5, 11:03 AM
Unknown Object (File)
Thu, Apr 4, 12:12 PM
Unknown Object (File)
Wed, Apr 3, 9:58 PM
Unknown Object (File)
Fri, Mar 29, 5:57 AM
Unknown Object (File)
Fri, Mar 29, 5:18 AM
Unknown Object (File)
Tue, Mar 26, 3:03 AM
Unknown Object (File)
Sat, Mar 23, 2:30 PM
View All Files
Subscribers
None

Details

Reviewers
chad
Maniphest Tasks
T7643: Improve prose diffs (was: description changes don't generate usable diffs)
Commits
rPHUad458fb7df59: (stable) Promote 2016 Week 24
rPHU87fa686beecd: (stable) Promote 2016 Week 23
rPHU7233ff63f821: Add a "summary" prose diff mode which omits unchanged text
Summary

Ref T7643. When a user edits a large wiki page, we currently show the entire page in the diff.

Provide a mode where we summarize unchanged text. This tries to just remove the middle section of big "=" changes that have multiple lines/paragraphs.

Test Plan

Unit tests.

Diff Detail

Repository
rPHU libphutil
Branch
diff7
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 12597
Build 15991: Run Core Tests
Build 15990: arc lint + arc unit

Event Timeline

epriestley updated this revision to Diff 38728.Jun 10 2016, 3:13 PM
epriestley retitled this revision from to Add a "summary" prose diff mode which omits unchanged text.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
epriestley added a task: T7643: Improve prose diffs (was: description changes don't generate usable diffs).
chad accepted this revision.Jun 10 2016, 4:25 PM
chad edited edge metadata.
This revision is now accepted and ready to land.Jun 10 2016, 4:25 PM
Closed by commit rPHU7233ff63f821: Add a "summary" prose diff mode which omits unchanged text (authored by epriestley, committed by epriestley). · Explain WhyJun 10 2016, 4:40 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
src/
utils/
85 lines
__tests__/
74 lines

Diff 38728

View Options

src/utils/PhutilProseDiff.php

Loading...
View Options

src/utils/__tests__/PhutilProseDiffTestCase.php

Loading...
Phabricator · Built by Phacility