Page MenuHomePhabricator

Allow prose and code diffs to use different smoothing
ClosedPublic

Authored by epriestley on Jun 7 2016, 8:43 PM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Mar 21, 10:30 PM
Unknown Object (File)
Thu, Mar 21, 9:51 PM
Unknown Object (File)
Thu, Mar 21, 8:38 PM
Unknown Object (File)
Thu, Mar 21, 7:23 PM
Unknown Object (File)
Thu, Mar 21, 6:49 PM
Unknown Object (File)
Wed, Mar 20, 3:45 PM
Unknown Object (File)
Mon, Mar 18, 7:07 PM
Unknown Object (File)
Mon, Mar 18, 6:35 PM
Subscribers
None

Details

Summary

Ref T7643. The prefix/suffix smoothing affected code diffs, and I think it's worse for them overall.

Generally, code has fewer real "words" than prose does. For example, if ($x) { or $x = ($y && $z); are not "words", and it's correct to highlight very limited parts of them.

Add separate "full" and "internal" smoothing modes for prose and code, respectively. I'll follow up by adjusting arcanist and phabricator.

Test Plan

arc unit --everything

Diff Detail

Repository
rPHU libphutil
Branch
prose10
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 12547
Build 15917: Run Core Tests
Build 15916: arc lint + arc unit

Event Timeline

epriestley retitled this revision from to Allow prose and code diffs to use different smoothing.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
chad edited edge metadata.
This revision is now accepted and ready to land.Jun 7 2016, 9:02 PM
This revision was automatically updated to reflect the committed changes.