Page MenuHomePhabricator

Fix some unit tests failures in Phabricator related to diff algorithm changes
AbandonedPublic

Authored by epriestley on Jun 7 2016, 8:32 PM.
Tags
None
Referenced Files
Unknown Object (File)
Nov 6 2022, 12:54 AM
Unknown Object (File)
Oct 5 2022, 1:18 AM
Unknown Object (File)
Sep 18 2022, 6:02 PM
Unknown Object (File)
Sep 11 2022, 9:50 PM
Unknown Object (File)
Sep 9 2022, 4:51 AM
Unknown Object (File)
Jul 22 2022, 12:42 PM
Unknown Object (File)
Jun 23 2022, 10:25 AM
Unknown Object (File)
Jun 9 2022, 10:35 AM
Subscribers
None

Details

Reviewers
chad
Summary

Making smoothing work better changed the results here slightly. I think the new results are legitimately preferable, but we could turn this into a couple of different modes if they cause problems.

Test Plan

arc unit --everything

Diff Detail

Repository
rP Phabricator
Branch
utest1
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 12546
Build 15915: Run Core Tests
Build 15914: arc lint + arc unit

Event Timeline

epriestley retitled this revision from to Fix some unit tests failures in Phabricator related to diff algorithm changes.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.

Actually, arc has some of this too and I don't like this behavior for code diffs for some of the changes there. I'm going to make code diffs stick with the old behavior.

Instead, D16073 fixes this by keeping the old algorithm for code diffs.