Page MenuHomePhabricator

Allow prose and code diffs to use different smoothing

Authored by epriestley on Jun 7 2016, 8:43 PM.
Referenced Files
Unknown Object (File)
Thu, Sep 22, 7:21 PM
Unknown Object (File)
Tue, Sep 20, 8:24 AM
Unknown Object (File)
Fri, Sep 16, 4:32 PM
Unknown Object (File)
Fri, Sep 16, 2:06 PM
Unknown Object (File)
Sat, Sep 3, 8:16 AM
Unknown Object (File)
Aug 7 2022, 11:40 AM
Unknown Object (File)
Aug 6 2022, 2:50 PM
Unknown Object (File)
Jul 19 2022, 12:03 PM



Ref T7643. The prefix/suffix smoothing affected code diffs, and I think it's worse for them overall.

Generally, code has fewer real "words" than prose does. For example, if ($x) { or $x = ($y && $z); are not "words", and it's correct to highlight very limited parts of them.

Add separate "full" and "internal" smoothing modes for prose and code, respectively. I'll follow up by adjusting arcanist and phabricator.

Test Plan

arc unit --everything

Diff Detail

rPHU libphutil
Lint Not Applicable
Tests Not Applicable

Event Timeline

epriestley retitled this revision from to Allow prose and code diffs to use different smoothing.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
chad edited edge metadata.
This revision is now accepted and ready to land.Jun 7 2016, 9:02 PM
This revision was automatically updated to reflect the committed changes.