Page MenuHomePhabricator

Allow prose and code diffs to use different smoothing
ClosedPublic

Authored by epriestley on Jun 7 2016, 8:43 PM.
Tags
None
Referenced Files
F14106028: D16073.diff
Wed, Nov 27, 4:13 AM
F14103793: D16073.id38678.diff
Tue, Nov 26, 10:48 PM
Unknown Object (File)
Sun, Nov 24, 8:17 AM
Unknown Object (File)
Mon, Nov 18, 7:51 PM
Unknown Object (File)
Thu, Nov 14, 4:43 PM
Unknown Object (File)
Sun, Nov 10, 8:16 PM
Unknown Object (File)
Thu, Nov 7, 1:59 PM
Unknown Object (File)
Wed, Oct 30, 4:17 PM
Subscribers
None

Details

Summary

Ref T7643. The prefix/suffix smoothing affected code diffs, and I think it's worse for them overall.

Generally, code has fewer real "words" than prose does. For example, if ($x) { or $x = ($y && $z); are not "words", and it's correct to highlight very limited parts of them.

Add separate "full" and "internal" smoothing modes for prose and code, respectively. I'll follow up by adjusting arcanist and phabricator.

Test Plan

arc unit --everything

Diff Detail

Repository
rPHU libphutil
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

epriestley retitled this revision from to Allow prose and code diffs to use different smoothing.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
chad edited edge metadata.
This revision is now accepted and ready to land.Jun 7 2016, 9:02 PM
This revision was automatically updated to reflect the committed changes.