Fix some unit tests failures in Phabricator related to diff algorithm changes
AbandonedPublic
Actions

Authored by epriestley on Jun 7 2016, 8:32 PM.

Details

Reviewers

Summary

Making smoothing work better changed the results here slightly. I think the new results are legitimately preferable, but we could turn this into a couple of different modes if they cause problems.

Test Plan

arc unit --everything

Diff Detail

Repository

rP Phabricator

Branch

utest1

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 12546
Build 15915: Run Core Tests
Build 15914: arc lint + arc unit

Event Timeline

epriestley updated this revision to Diff 38674.Jun 7 2016, 8:32 PM

epriestley retitled this revision from to Fix some unit tests failures in Phabricator related to diff algorithm changes.

epriestley updated this object.

epriestley edited the test plan for this revision. (Show Details)

epriestley added a reviewer: chad.

Actually, arc has some of this too and I don't like this behavior for code diffs for some of the changes there. I'm going to make code diffs stick with the old behavior.

epriestley planned changes to this revision.Jun 7 2016, 8:33 PM