Page MenuHomePhabricator

Move and update dog
AbandonedPublic

Authored by avivey on Jun 7 2016, 5:02 PM.
Tags
None
Referenced Files
F15527084: D16070.id38668.diff
Tue, Apr 22, 12:30 AM
F15508940: D16070.id.diff
Wed, Apr 16, 7:35 AM
F15505940: D16070.diff
Tue, Apr 15, 7:02 AM
F15505937: D16070.id.diff
Tue, Apr 15, 7:02 AM
F15505936: D16070.id38668.diff
Tue, Apr 15, 7:02 AM
F15505696: D16070.diff
Tue, Apr 15, 5:05 AM
F15503606: D16070.diff
Mon, Apr 14, 11:14 AM
F15467203: D16070.id.diff
Thu, Apr 3, 1:44 PM
Subscribers

Details

Reviewers
None
Summary

arc-patch fails to apply patches that rename and modify a binary file.

I've created this by moving the image and editing it's exif, so git and arc consider this "rename + change" instead of "delete and add".

The same thing happens in reality when updating a jar to the next version.

Test Plan

trying to arc-patch this diff fails

Downloading binary data for 'roomba-dog.jpg'...
Checking patch roomba-dog.jpg => dogs/roomba-dog.jpg...
error: the patch applies to 'roomba-dog.jpg' (fb5c503f27d80b12f96c3d850a3f4622f8014599), which does not match the current contents.
error: roomba-dog.jpg: patch does not apply

Diff Detail

Repository
rGITTEST git-test
Branch
arcpatch_1
Lint
No Lint Coverage
Unit
No Test Coverage
Build Status
Buildable 12540
Build 15904: arc lint + arc unit