Page MenuHomePhabricator

Move and update dog
AbandonedPublic

Authored by avivey on Jun 7 2016, 5:02 PM.
Tags
None
Referenced Files
F15200674: D16070.diff
Sun, Feb 23, 2:25 PM
Unknown Object (File)
Sat, Feb 22, 12:12 AM
Unknown Object (File)
Thu, Feb 20, 8:43 AM
Unknown Object (File)
Sun, Feb 16, 6:57 AM
Unknown Object (File)
Thu, Feb 13, 8:25 PM
Unknown Object (File)
Sun, Feb 9, 1:45 AM
Unknown Object (File)
Sun, Feb 9, 1:45 AM
Unknown Object (File)
Tue, Feb 4, 7:17 PM
Subscribers

Details

Reviewers
None
Summary

arc-patch fails to apply patches that rename and modify a binary file.

I've created this by moving the image and editing it's exif, so git and arc consider this "rename + change" instead of "delete and add".

The same thing happens in reality when updating a jar to the next version.

Test Plan

trying to arc-patch this diff fails

Downloading binary data for 'roomba-dog.jpg'...
Checking patch roomba-dog.jpg => dogs/roomba-dog.jpg...
error: the patch applies to 'roomba-dog.jpg' (fb5c503f27d80b12f96c3d850a3f4622f8014599), which does not match the current contents.
error: roomba-dog.jpg: patch does not apply

Diff Detail

Repository
rGITTEST git-test
Branch
arcpatch_1
Lint
No Lint Coverage
Unit
No Test Coverage
Build Status
Buildable 12540
Build 15904: arc lint + arc unit