Page MenuHomePhabricator

Apply edit smoothing to prose diffs

Authored by epriestley on Jun 7 2016, 3:21 PM.
Referenced Files
Unknown Object (File)
Tue, Nov 29, 3:17 PM
Unknown Object (File)
Mon, Nov 21, 10:26 PM
Unknown Object (File)
Mon, Nov 14, 5:52 AM
Unknown Object (File)
Mon, Nov 14, 4:53 AM
Unknown Object (File)
Thu, Nov 10, 6:25 PM
Unknown Object (File)
Thu, Nov 10, 6:18 PM
Unknown Object (File)
Thu, Nov 10, 1:56 PM
Unknown Object (File)
Wed, Nov 9, 11:40 PM



Ref T7643. Currently, when you edit one word into another word which shares some letters, we produce a very choppy diff. The edit from "says" into "remarks" on T7643 is one example.

These are technically correct (they minimize edit distance), but not how a human would diff them. A human can more easily parse an entire word change than the technically-more-accurate character-by-character diff.

Apply "smoothing" on these word-level and character-level diffs to avoid producing runs of changes when some characters are shared in a word edit.

We already do this in arc for normal intraline diffs (and have for years) and it seems to work well. I'll update that code to use this same method.

Test Plan

Add unit tests, ran unit tests.

Got a better diff in the UI for this class of edit:

Screen Shot 2016-06-07 at 8.14.52 AM.png (326×642 px, 58 KB)

Diff Detail

rPHU libphutil
Lint Not Applicable
Tests Not Applicable

Event Timeline

epriestley retitled this revision from to Apply edit smoothing to prose diffs.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
chad edited edge metadata.
This revision is now accepted and ready to land.Jun 7 2016, 3:53 PM
This revision was automatically updated to reflect the committed changes.