Page MenuHomePhabricator

Use EditDistanceMatrix diff smoothing in Arcanist
ClosedPublic

Authored by epriestley on Jun 7 2016, 3:27 PM.

Details

Summary

Ref T7643. We've done the smoothing from D16068 for a long time, it just wasn't part of EditDistanceMatrix.

Since it now is, call it instead of keeping a copy of the logic around.

Previously, the unit tests were testing un-smoothed diffs. Just have them test smoothed diffs instead, since nothing actually uses unsmoothed diffs.

Test Plan

Pasted a raw diff into the web UI, got a sensible inline diff for it.

Diff Detail

Repository
rARC Arcanist
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

epriestley retitled this revision from to Use EditDistanceMatrix diff smoothing in Arcanist.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
chad edited edge metadata.
This revision is now accepted and ready to land.Jun 7 2016, 4:09 PM
This revision was automatically updated to reflect the committed changes.