Page MenuHomePhabricator
Differential D15960

Move Tablet breakpoint from 768 -> 920
ClosedPublic
Actions

Authored by chad on May 21 2016, 7:10 PM.
Tags
None
Referenced Files
F13149841: D15960.diff
Sat, May 4, 11:47 AM
Unknown Object (File)
Thu, May 2, 3:25 PM
Unknown Object (File)
Thu, May 2, 7:05 AM
Unknown Object (File)
Mon, Apr 29, 5:04 PM
Unknown Object (File)
Fri, Apr 19, 4:43 PM
Unknown Object (File)
Sun, Apr 14, 3:59 PM
Unknown Object (File)
Thu, Apr 11, 9:46 AM
Unknown Object (File)
Mon, Apr 8, 4:07 PM
View All Files
Subscribers
avivey
Korvin

Details

Reviewers
epriestley
Maniphest Tasks
T10926: Make it more likely to see assignee & reporter in task view without having to scroll down
Commits
rPe902fc0e2a64: Move Tablet breakpoint from 768 -> 920
Summary

Bumping this up higher since two column views get extra tight fast below 900 px. This felt most correct to me, dialing it back from first attempt at 960. Mostly I don't want to ever accidentally trigger it when I'm on the 12" MacBook. Ref T10926

Test Plan

Durable Column, Workboards, Dashboards, Tasks.

Diff Detail

Repository
rP Phabricator
Branch
breakpoints (branched from master)
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 12299
Build 15549: Run Core Tests
Build 15548: arc lint + arc unit

Event Timeline

chad updated this revision to Diff 38425.May 21 2016, 7:10 PM
chad retitled this revision from to Move Tablet breakpoint from 768 -> 920.
chad updated this object.
chad edited the test plan for this revision. (Show Details)
chad added a reviewer: epriestley.
chad added a task: T10926: Make it more likely to see assignee & reporter in task view without having to scroll down.
Herald added a subscriber: Korvin. · View Herald TranscriptMay 21 2016, 7:10 PM
avivey added a subscriber: avivey.May 21 2016, 7:10 PM
epriestley accepted this revision.May 21 2016, 7:11 PM
epriestley edited edge metadata.
This revision is now accepted and ready to land.May 21 2016, 7:11 PM
Closed by commit rPe902fc0e2a64: Move Tablet breakpoint from 768 -> 920 (authored by chad, committed by chad). · Explain WhyMay 21 2016, 7:11 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
resources/
celerity/
50 lines
webroot/
rsrc/
css/
phui/
4 lines
js/
application/
conpherence/
2 lines
core/
2 lines

Diff 38425

View Options

resources/celerity/map.php

Loading...
View Options

webroot/rsrc/css/phui/phui-crumbs-view.css

Loading...
View Options

webroot/rsrc/js/application/conpherence/behavior-durable-column.js

Loading...
View Options

webroot/rsrc/js/core/behavior-device.js

Loading...
Phabricator · Built by Phacility