Page MenuHomePhabricator

Correctly detect new version of xhpast build
ClosedPublic

Authored by richardvanvelzen on May 19 2016, 10:52 AM.
Tags
None
Referenced Files
F15407279: D15945.id.diff
Tue, Mar 18, 4:37 PM
F15403529: D15945.diff
Tue, Mar 18, 3:43 AM
F15400118: D15945.diff
Mon, Mar 17, 9:49 AM
F15384362: D15945.id38395.diff
Fri, Mar 14, 7:38 PM
F15382809: D15945.id38398.diff
Fri, Mar 14, 2:33 PM
F15381167: D15945.diff
Fri, Mar 14, 6:13 AM
Unknown Object (File)
Thu, Feb 27, 5:34 AM
Unknown Object (File)
Wed, Feb 26, 8:36 PM
Subscribers

Details

Summary

When running lint after xhpast is updated, it tests whether the version is up-to-date. Because the version isn't reset before the test, it would think that the build failed, requiring a second run of lint

Test Plan

Downgraded xhpast, ran lint. Saw broken xhpast, but correct xhpast on second run. Applied patch, and got correct lint results regardless of version.

Diff Detail

Repository
rPHU libphutil
Branch
rebuild-xhpast
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 12267
Build 15501: arc lint + arc unit

Event Timeline

richardvanvelzen retitled this revision from to Correctly detect new version of xhpast build.
richardvanvelzen updated this object.
richardvanvelzen edited the test plan for this revision. (Show Details)
richardvanvelzen added a reviewer: epriestley.

Not really high-prio, but a minor annoyance after getting a fresh xhpast version.

epriestley edited edge metadata.
This revision is now accepted and ready to land.May 19 2016, 1:53 PM
chad added a reviewer: chad.
This revision was automatically updated to reflect the committed changes.