Differential D15934

Allow blocking reviewers to be added via the CLI
ClosedPublic
Actions

Authored by epriestley on May 17 2016, 12:54 AM.

Details

Reviewers

chad

Maniphest Tasks

T4887: Extend the blocking reviewers functionality universally
T10939: Support for OWNERS files

Commits

rP29a060d7f13f: Allow blocking reviewers to be added via the CLI

Summary

Ref T10939. Fixes T4887. Supports "username!" to add a reviewer as blocking.

Test Plan

Added and removed blocking and non-blocking reviewers via CLI.

Diff Detail

Repository

rP Phabricator

Branch

dash10

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 12238
Build 15459: Run Core Tests
Build 15458: arc lint + arc unit

Event Timeline

epriestley updated this revision to Diff 38365.May 17 2016, 12:54 AM

epriestley retitled this revision from to Allow blocking reviewers to be added via the CLI.

epriestley updated this object.

epriestley edited the test plan for this revision. (Show Details)

epriestley added a reviewer: chad.

epriestley added tasks: T10939: Support for OWNERS files, T4887: Extend the blocking reviewers functionality universally.

epriestley mentioned this in T10939: Support for OWNERS files.May 17 2016, 12:36 PM

chad accepted this revision.May 17 2016, 4:40 PM

chad edited edge metadata.

This revision is now accepted and ready to land.May 17 2016, 4:40 PM

Closed by commit rP29a060d7f13f: Allow blocking reviewers to be added via the CLI (authored by epriestley, committed by epriestley). · Explain WhyMay 17 2016, 5:56 PM

This revision was automatically updated to reflect the committed changes.

avivey mentioned this in T10981: Expected a scalar or null for %Ls conversion. Query: user.phid.May 18 2016, 12:41 AM

• donotreply mentioned this in T11010: Http502 when submitting or updating a diff.May 23 2016, 4:05 AM

Revision Contents
Changeset List

Path

Size

src/

applications/

differential/

customfield/

DifferentialCustomField.php

20 lines

DifferentialReviewersField.php

104 lines

phid/

query/

PhabricatorObjectListQuery.php

65 lines

__tests__/

PhabricatorObjectListQueryTestCase.php

33 lines

Diff 38365

View Options

src/applications/differential/customfield/DifferentialCustomField.php

View Options

src/applications/differential/customfield/DifferentialReviewersField.php

View Options

src/applications/phid/query/PhabricatorObjectListQuery.php

View Options

src/applications/phid/query/tests/PhabricatorObjectListQueryTestCase.php

Allow blocking reviewers to be added via the CLIClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 38365

src/applications/differential/customfield/DifferentialCustomField.php

src/applications/differential/customfield/DifferentialReviewersField.php

src/applications/phid/query/PhabricatorObjectListQuery.php

src/applications/phid/query/__tests__/PhabricatorObjectListQueryTestCase.php

Allow blocking reviewers to be added via the CLI
ClosedPublic
Actions

Revision Contents
Changeset List

src/applications/phid/query/tests/PhabricatorObjectListQueryTestCase.php