Page MenuHomePhabricator
Differential D15917

Allow Herald to add package reviewers
ClosedPublic
Actions

Authored by epriestley on May 13 2016, 6:35 PM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, Apr 17, 3:14 PM
Unknown Object (File)
Mon, Apr 15, 10:08 AM
Unknown Object (File)
Thu, Apr 11, 7:23 AM
Unknown Object (File)
Tue, Apr 9, 11:28 AM
Unknown Object (File)
Fri, Mar 29, 10:34 AM
Unknown Object (File)
Fri, Mar 29, 10:34 AM
Unknown Object (File)
Fri, Mar 29, 10:34 AM
Unknown Object (File)
Wed, Mar 27, 10:10 PM
View All Files
Subscribers
None

Details

Reviewers
chad
Maniphest Tasks
T10939: Support for OWNERS files
Commits
rP92b9fa47d00d: Allow Herald to add package reviewers
Summary

Ref T10939. Packages are valid reviewers, so let Herald "Add Reviewers" and "Add Blocking Reviewers" actions add them.

Test Plan
  • Wrote a rule to add package reviewers.
  • Hit the rule, saw a package reviewer added, viewed transcript.

Screen Shot 2016-05-13 at 11.33.53 AM.png (177×510 px, 30 KB)

Screen Shot 2016-05-13 at 11.33.46 AM.png (176×700 px, 30 KB)

Screen Shot 2016-05-13 at 11.32.56 AM.png (1×1 px, 162 KB)

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

epriestley updated this revision to Diff 38321.May 13 2016, 6:35 PM
epriestley retitled this revision from to Allow Herald to add package reviewers.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
epriestley added a task: T10939: Support for OWNERS files.
chad accepted this revision.May 13 2016, 7:49 PM
chad edited edge metadata.
This revision is now accepted and ready to land.May 13 2016, 7:49 PM
Closed by commit rP92b9fa47d00d: Allow Herald to add package reviewers (authored by epriestley, committed by epriestley). · Explain WhyMay 14 2016, 12:23 AM
This revision was automatically updated to reflect the committed changes.
epriestley mentioned this in T10939: Support for OWNERS files.May 14 2016, 1:02 AM
epriestley mentioned this in T5000: Using Differential with plain Git, without requiring Arc.May 20 2016, 11:04 PM

Revision Contents
Changeset List

Diff 38333

View Options

src/applications/differential/herald/DifferentialReviewersAddBlockingReviewersHeraldAction.php

Loading...
View Options

src/applications/differential/herald/DifferentialReviewersAddReviewersHeraldAction.php

Loading...
View Options

src/applications/differential/herald/DifferentialReviewersHeraldAction.php

Loading...
Phabricator · Built by Phacility