Page MenuHomePhabricator
Differential D15916

Support "Review Changes" and "Block Changes" settings for Owners package "Auto Review"
ClosedPublic
Actions

Authored by epriestley on May 13 2016, 6:30 PM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Dec 12, 10:34 PM
Unknown Object (File)
Thu, Dec 12, 10:34 PM
Unknown Object (File)
Thu, Dec 12, 10:34 PM
Unknown Object (File)
Thu, Dec 12, 10:34 PM
Unknown Object (File)
Fri, Dec 6, 11:22 PM
Unknown Object (File)
Fri, Dec 6, 9:21 PM
Unknown Object (File)
Tue, Dec 3, 8:41 PM
Unknown Object (File)
Tue, Dec 3, 3:07 AM
View All Files
Subscribers
None

Details

Reviewers
chad
Maniphest Tasks
T8887: Allow owners packages to add blocking reviewers
T10939: Support for OWNERS files
Commits
rP332d787dc8f4: Support "Review Changes" and "Block Changes" settings for Owners package…
Summary

Ref T10939. Fixes T8887. This enables and implements the "review" and "blocking review" options for packages.

This is a bit copy-pastey from DifferentialReviewersHeraldAction, which doesn't feel awesome. I think the right fix is Glorious Infrasturcture, though -- I filed T10967 to track that.

Test Plan
  • Set package autoreveiw to "Review".
  • Updated, got a reveiwer.
  • Set autoreview to "blocking".
  • Updated, got a blocking reviewer.

Screen Shot 2016-05-13 at 11.24.54 AM.png (157×516 px, 25 KB)

Screen Shot 2016-05-13 at 11.24.58 AM.png (108×434 px, 16 KB)

Screen Shot 2016-05-13 at 11.25.06 AM.png (211×405 px, 29 KB)

Diff Detail

Repository
rP Phabricator
Branch
owners9
Lint
Lint Passed
SeverityLocationCodeMessage
Advicesrc/applications/differential/editor/DifferentialTransactionEditor.php:1574XHP16TODO Comment
Unit
Tests Passed
Build Status
Buildable 12192
Build 15394: Run Core Tests
Build 15393: arc lint + arc unit

Event Timeline

epriestley updated this revision to Diff 38320.May 13 2016, 6:30 PM
epriestley retitled this revision from to Support "Review Changes" and "Block Changes" settings for Owners package "Auto Review".
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
epriestley added tasks: T10939: Support for OWNERS files, T8887: Allow owners packages to add blocking reviewers.
chad accepted this revision.May 13 2016, 7:40 PM
chad edited edge metadata.
This revision is now accepted and ready to land.May 13 2016, 7:40 PM
Closed by commit rP332d787dc8f4: Support "Review Changes" and "Block Changes" settings for Owners package… (authored by epriestley, committed by epriestley). · Explain WhyMay 14 2016, 12:22 AM
This revision was automatically updated to reflect the committed changes.
epriestley mentioned this in T10939: Support for OWNERS files.May 14 2016, 1:02 AM
epriestley mentioned this in T5000: Using Differential with plain Git, without requiring Arc.May 20 2016, 11:04 PM

Revision Contents
Changeset List

PathSize
src/
applications/
differential/
editor/
89 lines
owners/
storage/
13 lines
transactions/
editor/
8 lines

Diff 38320

View Options

src/applications/differential/editor/DifferentialTransactionEditor.php

Loading...
View Options

src/applications/owners/storage/PhabricatorOwnersPackage.php

Loading...
View Options

src/applications/transactions/editor/PhabricatorApplicationTransactionEditor.php

Loading...
Phabricator · Built by Phacility