Page MenuHomePhabricator
Differential D15907

Don't trigger audits for archived packages
ClosedPublic
Actions

Authored by epriestley on May 13 2016, 12:50 PM.
Tags
None
Referenced Files
F18804988: D15907.id38311.diff
Sat, Oct 18, 12:55 PM
F18785735: D15907.id38309.diff
Tue, Oct 14, 10:37 AM
F18646182: D15907.diff
Sep 19 2025, 9:41 AM
F18507522: D15907.id.diff
Sep 5 2025, 2:15 AM
F18487010: D15907.diff
Sep 3 2025, 7:09 PM
F18458226: D15907.id.diff
Sep 1 2025, 2:03 PM
F18453348: D15907.id38309.diff
Sep 1 2025, 3:33 AM
F18449165: D15907.diff
Sep 1 2025, 12:13 AM
View All Files
Subscribers
None

Details

Reviewers
chad
Maniphest Tasks
T10939: Support for OWNERS files
Commits
rPe5f2ccc57fb8: Don't trigger audits for archived packages
Summary

Ref T10939. This is just a bug. I thought this was what was described in T10174 but that's actually talking about something completely different.

Also make a <select /> slightly easier to use.

Test Plan
  • Created a package with auditing enabled.
  • Pushed a change.
  • Saw audit trigger.
  • Disabled the package, pushed a change.
    • Before patch: saw audit trigger improperly.
    • After patch: restarted daemons, then saw audit correctly not trigger.

Diff Detail

Repository
rP Phabricator
Branch
owners1
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 12181
Build 15374: Run Core Tests
Build 15373: arc lint + arc unit

Event Timeline

epriestley updated this revision to Diff 38309.May 13 2016, 12:50 PM
epriestley retitled this revision from to Don't trigger audits for archived packages.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
epriestley added a task: T10939: Support for OWNERS files.
chad accepted this revision.May 13 2016, 12:52 PM
chad edited edge metadata.
This revision is now accepted and ready to land.May 13 2016, 12:52 PM
Closed by commit rPe5f2ccc57fb8: Don't trigger audits for archived packages (authored by epriestley, committed by epriestley). · Explain WhyMay 13 2016, 1:49 PM
This revision was automatically updated to reflect the committed changes.
epriestley mentioned this in T9491: When packages are archived, packages shouldn't be listed as auditor.May 14 2016, 12:36 AM
epriestley mentioned this in T10181: Create audit requests based on a package commits.May 17 2016, 12:53 PM

Revision Contents
Changeset List

PathSize
src/
applications/
owners/
controller/
2 lines
repository/
worker/
5 lines

Diff 38309

View Options

src/applications/owners/controller/PhabricatorOwnersPathsController.php

Loading...
View Options

src/applications/repository/worker/PhabricatorRepositoryCommitOwnersWorker.php

Loading...
Phabricator · Built by Phacility