Page MenuHomePhabricator

Add a "View Revision" button to HTML email

Authored by chad on May 11 2016, 1:12 AM.
Referenced Files
Unknown Object (File)
Sun, Aug 7, 1:08 AM
Unknown Object (File)
Thu, Aug 4, 6:26 AM
Unknown Object (File)
Mon, Aug 1, 7:45 PM
Unknown Object (File)
Fri, Jul 29, 12:51 AM
Unknown Object (File)
Wed, Jul 27, 7:40 PM
Unknown Object (File)
Mon, Jul 25, 2:17 AM
Unknown Object (File)
Fri, Jul 22, 5:19 PM
Unknown Object (File)
Mon, Jul 18, 4:54 PM
"Love" token, awarded by avivey.



Ref T10694. If this feels good, I'd plan to eventually add something similar to other applications ("View Task", etc).

Not sure if we should keep the object link later in the mail body or not. I left it for now.

Test Plan

Screen Shot 2016-05-10 at 6.10.05 PM.png (348×956 px, 58 KB)

Diff Detail

rP Phabricator
Lint Not Applicable
Tests Not Applicable

Event Timeline

epriestley retitled this revision from to Add a "View Revision" button to HTML email.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.

I don't particularly love my design here, not sure if you have any ideas. Some things I might try:

  • Get rid of the background and bottom border?
  • Make the button a little "lighter weight" visually so it's more like a link than a button? I do want it to stand out a bit but using the "grey" style or something similar with a touch of color might feel better.

If we want to make html the default, I'll spend some time on it Monday, unless you want to ship something sooner.

Sounds good, definitely no rush. Might be a good time to play around with simplifying the footer a bit too (e.g., just a "Preferences" link).

chad edited reviewers, added: epriestley; removed: chad.
  • remove all personality

This is a bit bare bones, but feels decent on my desktop and phone.

epriestley edited edge metadata.


This revision is now accepted and ready to land.May 18 2016, 9:23 PM

(I think simple is probably pretty good in email.)

I think i might use it actually, at least on mobile.

This revision was automatically updated to reflect the committed changes.

Of course doesn't render in my daily use mobile client. But Apple is fine.

I get this as a body summary too now ("View Revision" at the beginning), although there's probably nothing we can really do about that:

Screen Shot 2016-05-18 at 3.33.31 PM.png (107×265 px, 17 KB)

There's maybe more whitespace than we need here, too, between the button and the comment:

Screen Shot 2016-05-18 at 3.34.28 PM.png (55×820 px, 12 KB)

should be easy to fix those both.