Page MenuHomePhabricator
Differential D15833

Add unpack support to xhpast
ClosedPublic
Actions

Authored by richardvanvelzen on May 2 2016, 3:02 PM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Jan 30, 11:07 PM
Unknown Object (File)
Wed, Jan 29, 3:24 PM
Unknown Object (File)
Wed, Jan 29, 9:29 AM
Unknown Object (File)
Mon, Jan 27, 4:26 PM
Unknown Object (File)
Fri, Jan 24, 1:46 PM
Unknown Object (File)
Fri, Jan 24, 1:46 PM
Unknown Object (File)
Wed, Jan 22, 7:55 AM
Unknown Object (File)
Tue, Jan 21, 8:19 PM
View All Files
Subscribers
Korvin

Details

Reviewers
epriestley
Group Reviewers
Blessed Reviewers
Commits
rPHU0709cd5cfc26: Add unpack support to xhpast
Test Plan
cd support/xhpast
make cleanall
make
cd ../../
scripts/build_xhpast.php
arc unit

Diff Detail

Repository
rPHU libphutil
Branch
xhpast-unpack
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 12016
Build 15120: arc lint + arc unit

Event Timeline

richardvanvelzen updated this revision to Diff 38140.May 2 2016, 3:02 PM
richardvanvelzen retitled this revision from to Add unpack support to xhpast.
richardvanvelzen updated this object.
richardvanvelzen edited the test plan for this revision. (Show Details)
richardvanvelzen added a reviewer: epriestley.
Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptMay 2 2016, 3:02 PM
Herald added a subscriber: Korvin. · View Herald Transcript
richardvanvelzen added inline comments.May 2 2016, 3:06 PM
support/xhpast/parser.y
1108–1111

I've updated this part to match PHP 7's behaviour. Call-time pass-by-ref no longer exists, so unpack needn't support it either.

epriestley accepted this revision.May 2 2016, 3:12 PM
epriestley edited edge metadata.

Thanks!

This revision is now accepted and ready to land.May 2 2016, 3:12 PM
Closed by commit rPHU0709cd5cfc26: Add unpack support to xhpast (authored by richardvanvelzen, committed by richardvanvelzen). · Explain WhyMay 2 2016, 3:17 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
src/
parser/
xhpast/
__tests__/
data/
4 lines
173 lines
bin/
2 lines
support/
xhpast/
27 lines
4905 lines
25 lines
72 lines
2 lines

Diff 38140

View Options

src/parser/xhpast/__tests__/data/unpack-fail.php.test

Loading...
View Options

src/parser/xhpast/__tests__/data/variadic.php.test

Loading...
View Options

src/parser/xhpast/bin/PhutilXHPASTBinary.php

Loading...
View Options

support/xhpast/parser.y

Loading...
View Options

support/xhpast/parser.yacc.cpp

Loading...
View Options

support/xhpast/scanner.lex.hpp

Loading...
View Options

support/xhpast/scanner.lex.cpp

Loading...
View Options

support/xhpast/xhpast.cpp

Loading...
Phabricator · Built by Phacility