Page MenuHomePhabricator

Correct RepositoryURI schema and propagate `adjust` exit code correctly
ClosedPublic

Authored by epriestley on Apr 18 2016, 3:07 PM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, Sep 21, 7:11 AM
Unknown Object (File)
Sun, Sep 18, 1:26 AM
Unknown Object (File)
Sat, Sep 17, 12:07 AM
Unknown Object (File)
Wed, Sep 7, 1:10 PM
Unknown Object (File)
Wed, Sep 7, 2:54 AM
Unknown Object (File)
Wed, Aug 31, 6:02 AM
Unknown Object (File)
Aug 14 2022, 10:30 AM
Unknown Object (File)
Aug 8 2022, 11:19 PM
Subscribers
None

Details

Summary

Fixes T10830.

  • The return code from storage adjust did not propagate correct.
  • There was one column issue which I missed the first time around because I had a bunch of unrelated stuff locally.
Test Plan
  • Ran bin/storage upgrade -f with failures, used echo $? to make sure it exited nonzero.
  • Got fully clean bin/storage adjust by dropping all my extra local tables.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

epriestley retitled this revision from to Correct RepositoryURI schema and propagate `adjust` exit code correctly.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
chad edited edge metadata.
This revision is now accepted and ready to land.Apr 18 2016, 3:11 PM
This revision was automatically updated to reflect the committed changes.