Page MenuHomePhabricator
Differential D15573

Strip tips out of commit messages from `arc backout`
ClosedPublic
Actions

Authored by epriestley on Apr 2 2016, 1:29 PM.
Tags
None
Referenced Files
F14961601: D15573.diff
Sun, Feb 16, 6:35 AM
Unknown Object (File)
Sun, Feb 9, 1:10 AM
Unknown Object (File)
Sun, Feb 9, 1:10 AM
Unknown Object (File)
Sun, Feb 9, 1:10 AM
Unknown Object (File)
Sun, Feb 9, 1:10 AM
Unknown Object (File)
Thu, Jan 30, 8:34 AM
Unknown Object (File)
Fri, Jan 24, 12:43 PM
Unknown Object (File)
Fri, Jan 24, 12:43 PM
View All Files
Subscribers
None

Details

Reviewers
chad
Maniphest Tasks
T10707: arc backout added bonus free "tips" to end of commit message
Commits
rARC68f4a77d42c5: (stable) Promote 2016 Week 15
rARC8701e6c1f31a: Strip tips out of commit messages from `arc backout`
Summary

Fixes T10707. Currently, arc backout creates a commit message which includes questionably-helpful "tips" in the message itself.

Strip these out.

Test Plan

Used arc backout to revert any commit, then git show to see the generated message.

  • Before patch: included tips.
  • After patch: no tips.

Diff Detail

Repository
rARC Arcanist
Branch
backout
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 11408
Build 14215: Run Core Tests
Build 14214: arc lint + arc unit

Event Timeline

epriestley updated this revision to Diff 37541.Apr 2 2016, 1:29 PM
epriestley retitled this revision from to Strip tips out of commit messages from `arc backout`.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
epriestley added a task: T10707: arc backout added bonus free "tips" to end of commit message.
epriestley mentioned this in T10707: arc backout added bonus free "tips" to end of commit message.Apr 2 2016, 1:31 PM
chad accepted this revision.Apr 2 2016, 2:20 PM
chad edited edge metadata.
This revision is now accepted and ready to land.Apr 2 2016, 2:20 PM
Closed by commit rARC8701e6c1f31a: Strip tips out of commit messages from `arc backout` (authored by epriestley, committed by epriestley). · Explain WhyApr 2 2016, 2:26 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
src/
workflow/
3 lines

Diff 37541

View Options

src/workflow/ArcanistBackoutWorkflow.php

Loading...
Phabricator · Built by Phacility