Paths

Table of Contentst

Differential D15500

Unbreak regex filename search
ClosedPublic
Actions

Authored by vlada on Mar 20 2016, 2:13 PM.

Details

Reviewers

epriestley

Group Reviewers

Blessed Reviewers

Commits

Restricted Diffusion Commit
rP130e1d1f68a4: Unbreak regex filename search

Summary

D9087 adds a nice typeahead but breaks the existing regex
search by quoting the pattern. Ideally, this change won't break the
typeahead, which as far as I can tell doesn't use the pattern
argument.

Test Plan

Not yet.
RFC as to whether this change makes sense, will fix my local setup and resend if so.

Diff Detail

Repository

rP Phabricator

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

vlada updated this revision to Diff 37366.Mar 20 2016, 2:13 PM

vlada retitled this revision from to Unbreak regex filename search.

vlada updated this object.

vlada edited the test plan for this revision. (Show Details)

vlada added a reviewer: epriestley.

Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptMar 20 2016, 2:13 PM

Herald added a subscriber: Korvin. · View Herald Transcript

vlada edited the test plan for this revision. (Show Details)Mar 20 2016, 2:14 PM

vlada edited edge metadata.

I think this is alright. This should be a little cleaner:

$pattern = '('.$pattern.')';

change as per code review

epriestley accepted this revision.Mar 20 2016, 5:15 PM

epriestley edited edge metadata.

This revision is now accepted and ready to land.Mar 20 2016, 5:15 PM

Closed by commit rP130e1d1f68a4: Unbreak regex filename search (authored by vlada, committed by epriestley). · Explain WhyMar 20 2016, 5:15 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

applications/

diffusion/

conduit/

DiffusionQueryPathsConduitAPIMethod.php

3 lines

Diff 37368

View Options

src/applications/diffusion/conduit/DiffusionQueryPathsConduitAPIMethod.php

Unbreak regex filename searchClosedPublicActions