Page MenuHomePhabricator

Unbreak regex filename search
ClosedPublic

Authored by vlada on Mar 20 2016, 2:13 PM.

Details

Reviewers
epriestley
Group Reviewers
Blessed Reviewers
Commits
Restricted Diffusion Commit
rP130e1d1f68a4: Unbreak regex filename search
Summary

D9087 adds a nice typeahead but breaks the existing regex
search by quoting the pattern. Ideally, this change won't break the
typeahead, which as far as I can tell doesn't use the pattern
argument.

Test Plan

Not yet.
RFC as to whether this change makes sense, will fix my local setup and resend if so.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

vlada retitled this revision from to Unbreak regex filename search.
vlada updated this object.
vlada edited the test plan for this revision. (Show Details)
vlada added a reviewer: epriestley.
vlada edited edge metadata.

I think this is alright. This should be a little cleaner:

$pattern = '('.$pattern.')';
vlada edited edge metadata.

change as per code review

epriestley edited edge metadata.
This revision is now accepted and ready to land.Mar 20 2016, 5:15 PM
This revision was automatically updated to reflect the committed changes.