Page MenuHomePhabricator
Differential D15499

Only require view permissions for read-only Git LFS requests
ClosedPublic
Actions

Authored by epriestley on Mar 19 2016, 6:11 PM.
Tags
None
Referenced Files
F13077689: D15499.id37360.diff
Tue, Apr 23, 3:02 AM
F13077687: D15499.id37361.diff
Tue, Apr 23, 3:01 AM
F13073868: D15499.id37361.diff
Mon, Apr 22, 11:16 PM
Unknown Object (File)
Wed, Apr 17, 12:23 PM
Unknown Object (File)
Fri, Mar 29, 3:23 PM
Unknown Object (File)
Fri, Mar 29, 1:59 AM
Unknown Object (File)
Mar 5 2024, 6:56 AM
Unknown Object (File)
Feb 17 2024, 10:15 PM
View All Files
Subscribers
None

Details

Reviewers
chad
Maniphest Tasks
T7789: Support Git Large File Storage
Commits
Restricted Diffusion Commit
rP76f07ec80bde: Only require view permissions for read-only Git LFS requests
Summary

Ref T7789. Implement proper detection for read-only requests. Previously, we assumed every request was read/write and required lots of permissions, but we don't need "Can Push" permission if you're only cloning/fetching/pulling.

Test Plan
  • Set push policy to "no one".
  • Fetched, got clean data out of LFS.
  • Tried to push, got useful error.

Diff Detail

Repository
rP Phabricator
Branch
lfs15
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 11223
Build 13932: Run Core Tests
Build 13931: arc lint + arc unit

Event Timeline

epriestley updated this revision to Diff 37360.Mar 19 2016, 6:11 PM
epriestley retitled this revision from to Only require view permissions for read-only Git LFS requests.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
epriestley added a task: T7789: Support Git Large File Storage.
Herald edited edge metadata. · View Herald TranscriptMar 19 2016, 6:11 PM
epriestley updated this revision to Diff 37361.Mar 19 2016, 8:09 PM
epriestley edited edge metadata.
  • Also do set_time_limit(0).
Herald edited edge metadata. · View Herald TranscriptMar 19 2016, 8:09 PM
epriestley mentioned this in T7789: Support Git Large File Storage.Mar 19 2016, 8:20 PM
chad accepted this revision.Mar 19 2016, 9:22 PM
chad edited edge metadata.
This revision is now accepted and ready to land.Mar 19 2016, 9:22 PM
Closed by commit rP76f07ec80bde: Only require view permissions for read-only Git LFS requests (authored by epriestley, committed by epriestley). · Explain WhyMar 19 2016, 9:23 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
src/
applications/
diffusion/
controller/
59 lines

Diff 37360

View Options

src/applications/diffusion/controller/DiffusionServeController.php

Loading...
Phabricator · Built by Phacility