Remove recently added repository_pathchange key
ClosedPublic
Actions

Authored by epriestley on Mar 16 2016, 9:50 PM.

Details

Reviewers

eadler
chad

Maniphest Tasks

T10560: Find ways to detect/fix/warn about MySQL indexes with poor cardinality estimates

Commits

Restricted Diffusion Commit
rP5520729db3d5: Remove recently added repository_pathchange key

Summary

Ref T10560. Reverts D15460. See that task for discussion: we dug up some more information to explain the behavior, and this key was just sort of sidestepping an analyze/cardinality estimate issue on the index.

With proper cardinality estimates it shouldn't be used, so just nuke it.

Test Plan

Ran bin/storage adjust, saw key drop.

Diff Detail

Repository

rP Phabricator

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

epriestley updated this revision to Diff 37321.Mar 16 2016, 9:50 PM

epriestley retitled this revision from to Remove recently added repository_pathchange key.

epriestley updated this object.

epriestley edited the test plan for this revision. (Show Details)

epriestley added reviewers: chad, eadler.

epriestley added a task: T10560: Find ways to detect/fix/warn about MySQL indexes with poor cardinality estimates.

Herald edited edge metadata. · View Herald TranscriptMar 16 2016, 9:50 PM

chad accepted this revision.Mar 16 2016, 9:52 PM

chad edited edge metadata.

This revision is now accepted and ready to land.Mar 16 2016, 9:52 PM

Closed by commit rP5520729db3d5: Remove recently added repository_pathchange key (authored by epriestley, committed by epriestley). · Explain WhyMar 16 2016, 9:58 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

applications/

repository/

storage/

PhabricatorRepositorySchemaSpec.php

3 lines

Diff 37322

View Options

src/applications/repository/storage/PhabricatorRepositorySchemaSpec.php

Remove recently added repository_pathchange keyClosedPublicActions