Page MenuHomePhabricator
Differential D15486

Remove recently added repository_pathchange key
ClosedPublic
Actions

Authored by epriestley on Mar 16 2016, 9:50 PM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, May 3, 5:14 AM
Unknown Object (File)
Thu, Apr 25, 12:49 AM
Unknown Object (File)
Wed, Apr 24, 4:24 PM
Unknown Object (File)
Mon, Apr 22, 1:53 PM
Unknown Object (File)
Fri, Apr 19, 4:20 PM
Unknown Object (File)
Sun, Apr 14, 1:04 AM
Unknown Object (File)
Sat, Apr 6, 10:35 AM
Unknown Object (File)
Sat, Apr 6, 7:48 AM
View All Files
Subscribers
None

Details

Reviewers
eadler
chad
Maniphest Tasks
T10560: Find ways to detect/fix/warn about MySQL indexes with poor cardinality estimates
Commits
Restricted Diffusion Commit
rP5520729db3d5: Remove recently added repository_pathchange key
Summary

Ref T10560. Reverts D15460. See that task for discussion: we dug up some more information to explain the behavior, and this key was just sort of sidestepping an analyze/cardinality estimate issue on the index.

With proper cardinality estimates it shouldn't be used, so just nuke it.

Test Plan

Ran bin/storage adjust, saw key drop.

Diff Detail

Repository
rP Phabricator
Branch
analyze1
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 11181
Build 13872: Run Core Tests
Build 13871: arc lint + arc unit

Event Timeline

epriestley updated this revision to Diff 37321.Mar 16 2016, 9:50 PM
epriestley retitled this revision from to Remove recently added repository_pathchange key.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added reviewers: chad, eadler.
epriestley added a task: T10560: Find ways to detect/fix/warn about MySQL indexes with poor cardinality estimates.
Herald edited edge metadata. · View Herald TranscriptMar 16 2016, 9:50 PM
chad accepted this revision.Mar 16 2016, 9:52 PM
chad edited edge metadata.
This revision is now accepted and ready to land.Mar 16 2016, 9:52 PM
Closed by commit rP5520729db3d5: Remove recently added repository_pathchange key (authored by epriestley, committed by epriestley). · Explain WhyMar 16 2016, 9:58 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
src/
applications/
repository/
storage/
3 lines

Diff 37321

View Options

src/applications/repository/storage/PhabricatorRepositorySchemaSpec.php

Loading...
Phabricator · Built by Phacility