Page MenuHomePhabricator

Add a key to improve Diffusion's cache fill history query
ClosedPublic

Authored by epriestley on Mar 11 2016, 1:36 AM.
Tags
None
Referenced Files
F15538786: D15460.diff
Thu, Apr 24, 9:33 PM
F15532558: D15460.id.diff
Wed, Apr 23, 4:16 PM
F15453258: D15460.id37257.diff
Mar 29 2025, 10:30 AM
F15446105: D15460.id37256.diff
Mar 27 2025, 5:13 PM
F15445731: D15460.id.diff
Mar 27 2025, 3:43 PM
F15440502: D15460.diff
Mar 26 2025, 1:01 PM
F15417889: D15460.id37256.diff
Mar 20 2025, 7:12 PM
F15407974: D15460.id37256.diff
Mar 18 2025, 8:32 PM
Subscribers
None

Details

Summary

Ref T10560. I don't fully understand what MySQL is doing here, but it looks like this key improves the problematic dataset in practice.

(It makes sense that this key helps, I'm just not sure why the two separate keys and the UNION ALL are so bad.)

This key isn't hugely expensive to add, so we can try it and see if there are still issues.

Test Plan

Ran bin/storage adjust, saw key added to table. Used SHOW CREATE TABLE ... to verify the key exists. Used EXPLAIN SELECT ... to make sure MySQL actually uses it.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable