Page MenuHomePhabricator

Allow Almanac interfaces to be browsed
ClosedPublic

Authored by epriestley on Feb 21 2016, 11:25 AM.

Details

Summary

Fixes T10205. Ref T10246. Previously, the issue was that the result set was not ordered, so "More Results" would not have been able to work in a reasonable way if there were more than 100 matching interfaces.

You would have seen 100 interfaces more or less at random, then clicked "more" and gotten 100 more random interfaces.

Now, you would see 100 "a" interfaces, then click more to get the next 100 alphabetical interfaces (say, "b" and "c" interfaces).

Test Plan
  • Clicked browse when binding an interface.
  • Got a browse dialog.
  • Artificially set query limit to 1, paged through "local" interfaces in an ordered, consistent way.

Screen Shot 2016-02-21 at 3.22.11 AM.png (1×1 px, 158 KB)

Diff Detail

Repository
rP Phabricator
Branch
almanac2
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 10790
Build 13286: Run Core Tests
Build 13285: arc lint + arc unit

Event Timeline

epriestley retitled this revision from to Allow Almanac interfaces to be browsed.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
chad edited edge metadata.
This revision is now accepted and ready to land.Feb 21 2016, 3:43 PM
This revision was automatically updated to reflect the committed changes.