Paths

Table of Contentst

Differential D15212

Fix incorrect variable for linter standards
ClosedPublic
Actions

Authored by joshuaspence on Feb 8 2016, 4:17 AM.

Tags

None

Referenced Files

	F15689887: D15212.diff
	Wed, May 28, 12:37 AM

	Unknown Object (File)
	Sun, May 25, 6:59 AM

	Unknown Object (File)
	Sat, May 10, 9:33 PM

	Unknown Object (File)
	Tue, May 6, 11:15 AM

	Unknown Object (File)
	Tue, Apr 29, 10:24 AM

	Unknown Object (File)
	Tue, Apr 29, 9:24 AM

	Unknown Object (File)
	Apr 28 2025, 6:29 AM

	Unknown Object (File)
	Apr 27 2025, 9:40 AM

Subscribers

Details

Reviewers

Group Reviewers

Blessed Reviewers

Commits

rARCea6fc7789295: Fix incorrect variable for linter standards

Summary

It is currently not possible to apply multiple linter standards because $value was used instead of $standard.

Test Plan

Was able to apply multiple linter standards.

Diff Detail

Repository

Branch

master

Lint

Lint Passed

Unit

Test Failures

Build Status

Buildable 10560
Build 12940: Run Core Tests
Build 12939: arc lint + arc unit

Unit TestsFailed
View All

	Time	Test
	994 ms	ArcanistPuppetLintLinterTestCase::Unknown Unit Message ("")
	24 ms	ArcanistAbstractMethodBodyXHPASTLinterRuleTestCase::Unknown Unit Message ("")
	10 ms	ArcanistAbstractPrivateMethodXHPASTLinterRuleTestCase::Unknown Unit Message ("")
	10 ms	ArcanistAliasFunctionXHPASTLinterRuleTestCase::Unknown Unit Message ("")
	10 ms	ArcanistArrayCombineXHPASTLinterRuleTestCase::Unknown Unit Message ("")
		View Full Test Results (1 Failed · 209 Passed · 44 Skipped)

Event Timeline

joshuaspence updated this revision to Diff 36720.Feb 8 2016, 4:17 AM

joshuaspence retitled this revision from to Fix incorrect variable for linter standards.

joshuaspence updated this object.

joshuaspence edited the test plan for this revision. (Show Details)

joshuaspence added a reviewer: epriestley.

Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptFeb 8 2016, 4:17 AM

Herald added a subscriber: Korvin. · View Herald Transcript

Can someone please review and accept this fix?

The unit tests failed. Have you looked into why?

epriestley accepted this revision.Mar 21 2016, 5:12 PM

epriestley edited edge metadata.

This revision is now accepted and ready to land.Mar 21 2016, 5:12 PM

That puppet thing is some version issue in the vein of T9456.

Closed by commit rARCea6fc7789295: Fix incorrect variable for linter standards (authored by joshuaspence, committed by eadler). · Explain WhyApr 29 2016, 8:00 AM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

Coverage (All)

Coverage (Touched)

src/

lint/

linter/

ArcanistLinter.php

6 lines

47%

Loading...

Diff 36720

src/lint/linter/ArcanistLinter.php

Loading...