Page MenuHomePhabricator
Differential D15212

Fix incorrect variable for linter standards
ClosedPublic
Actions

Authored by joshuaspence on Feb 8 2016, 4:17 AM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Apr 25, 1:38 AM
Unknown Object (File)
Sun, Apr 21, 7:10 AM
Unknown Object (File)
Wed, Apr 17, 2:51 PM
Unknown Object (File)
Tue, Apr 16, 6:06 AM
Unknown Object (File)
Apr 3 2024, 7:36 AM
Unknown Object (File)
Apr 2 2024, 1:29 PM
Unknown Object (File)
Apr 2 2024, 1:29 PM
Unknown Object (File)
Mar 29 2024, 9:28 PM
View All Files
Subscribers
eadler
Korvin
thaiphv

Details

Reviewers
epriestley
Group Reviewers
Blessed Reviewers
Commits
rARCea6fc7789295: Fix incorrect variable for linter standards
Summary

It is currently not possible to apply multiple linter standards because $value was used instead of $standard.

Test Plan

Was able to apply multiple linter standards.

Diff Detail

Repository
rARC Arcanist
Branch
master
Lint
Lint Passed
Unit
Test Failures
Build Status
Buildable 10560
Build 12940: Run Core Tests
Build 12939: arc lint + arc unit

Unit TestsFailed
View All

TimeTest
994 msArcanistPuppetLintLinterTestCase::Unknown Unit Message ("")
24 msArcanistAbstractMethodBodyXHPASTLinterRuleTestCase::Unknown Unit Message ("")
10 msArcanistAbstractPrivateMethodXHPASTLinterRuleTestCase::Unknown Unit Message ("")
10 msArcanistAliasFunctionXHPASTLinterRuleTestCase::Unknown Unit Message ("")
10 msArcanistArrayCombineXHPASTLinterRuleTestCase::Unknown Unit Message ("")
View Full Test Results (1 Failed · 209 Passed · 44 Skipped)

Event Timeline

joshuaspence updated this revision to Diff 36720.Feb 8 2016, 4:17 AM
joshuaspence retitled this revision from to Fix incorrect variable for linter standards.
joshuaspence updated this object.
joshuaspence edited the test plan for this revision. (Show Details)
joshuaspence added a reviewer: epriestley.
Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptFeb 8 2016, 4:17 AM
Herald added a subscriber: Korvin. · View Herald Transcript
thaiphv added a subscriber: thaiphv.Mar 21 2016, 1:09 AM

Can someone please review and accept this fix?

eadler added a subscriber: eadler.Mar 21 2016, 5:02 AM

The unit tests failed. Have you looked into why?

epriestley accepted this revision.Mar 21 2016, 5:12 PM
epriestley edited edge metadata.
This revision is now accepted and ready to land.Mar 21 2016, 5:12 PM
epriestley added a comment.Mar 21 2016, 5:12 PM

That puppet thing is some version issue in the vein of T9456.

Closed by commit rARCea6fc7789295: Fix incorrect variable for linter standards (authored by joshuaspence, committed by eadler). · Explain WhyApr 29 2016, 8:00 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSizeCoverage (All)Coverage (Touched)
src/
lint/
linter/
6 lines47%
Loading...

Diff 36720

View Options

src/lint/linter/ArcanistLinter.php

Loading...
Phabricator · Built by Phacility