Fix bad call to getShortName()
ClosedPublic
Actions

Authored by epriestley on Jan 24 2016, 1:04 AM.

Tags

None

Referenced Files

	F13179335: D15100.diff
	Wed, May 8, 9:07 PM

	Unknown Object (File)
	Sat, May 4, 6:33 PM

	Unknown Object (File)
	Wed, Apr 24, 11:48 PM

	Unknown Object (File)
	Apr 13 2024, 5:41 AM

	Unknown Object (File)
	Apr 11 2024, 8:02 AM

	Unknown Object (File)
	Apr 10 2024, 10:04 PM

	Unknown Object (File)
	Apr 7 2024, 2:00 PM

	Unknown Object (File)
	Mar 31 2024, 9:00 AM

View All Files

Subscribers

None

Details

Reviewers

chad

Maniphest Tasks

T10212: Toggling syntax highlighting in Diffusion causes Unhandled Exception

Commits

Restricted Diffusion Commit
rPb53d61c90915: Fix bad call to getShortName()

Summary

Fixes T10212. This method was removed in D14990, but I missed a callsite.

Test Plan

Disabling blame now works nicely.

Diff Detail

Repository

rP Phabricator

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

epriestley updated this revision to Diff 36459.Jan 24 2016, 1:04 AM

epriestley retitled this revision from to Fix bad call to getShortName().

epriestley updated this object.

epriestley edited the test plan for this revision. (Show Details)

epriestley added a reviewer: chad.

epriestley added a task: T10212: Toggling syntax highlighting in Diffusion causes Unhandled Exception.

chad accepted this revision.Jan 24 2016, 1:06 AM

chad edited edge metadata.

This revision is now accepted and ready to land.Jan 24 2016, 1:06 AM

Closed by commit rPb53d61c90915: Fix bad call to getShortName() (authored by epriestley, committed by epriestley). · Explain WhyJan 24 2016, 1:07 AM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

applications/

diffusion/

controller/

DiffusionBrowseController.php

2 lines

Diff 36461

View Options

src/applications/diffusion/controller/DiffusionBrowseController.php

Fix bad call to getShortName()ClosedPublicActions