Paths

Table of Contentst

Differential D14990

Introduce "local names" for commits
ClosedPublic
Actions

Authored by epriestley on Jan 11 2016, 10:52 AM.

Tags

None

Referenced Files

	F13083633: D14990.diff
	Wed, Apr 24, 10:40 PM

	Unknown Object (File)
	Fri, Apr 19, 4:05 PM

	Unknown Object (File)
	Tue, Apr 16, 12:47 PM

	Unknown Object (File)
	Thu, Apr 11, 7:37 AM

	Unknown Object (File)
	Tue, Apr 9, 2:32 AM

	Unknown Object (File)
	Sun, Mar 31, 10:40 PM

	Unknown Object (File)
	Sun, Mar 31, 1:19 AM

	Unknown Object (File)
	Thu, Mar 28, 5:41 PM

Subscribers

None

Details

Reviewers

Maniphest Tasks

T4245: Make repository URIs slightly prettier

Commits

Restricted Diffusion Commit
rPb848ab87b3d5: Introduce "local names" for commits

Summary

Ref T4245. Full commit display names (like rPaaaa) are going to be obnoxious soon in some cases (e.g., rPaaaa becomes R123:aaaa, which is much uglier) so reduce how often we show the repository in cases where it isn't really necessary to include it.

Test Plan

Saw no more rX on repository list view for Git/Mercurial (still present for Subversion).
Saw no more rX on various repository detail views, except when referencing other commits (e.g., mentions).
Grepped for removed getShortName().

Diff Detail

Repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

epriestley updated this revision to Diff 36211.Jan 11 2016, 10:52 AM

epriestley retitled this revision from to Introduce "local names" for commits.

epriestley updated this object.

epriestley edited the test plan for this revision. (Show Details)

epriestley added a reviewer: chad.

epriestley added a task: T4245: Make repository URIs slightly prettier.

chad accepted this revision.Jan 11 2016, 4:57 PM

chad edited edge metadata.

This revision is now accepted and ready to land.Jan 11 2016, 4:57 PM

Closed by commit rPb848ab87b3d5: Introduce "local names" for commits (authored by epriestley, committed by epriestley). · Explain WhyJan 11 2016, 5:18 PM

This revision was automatically updated to reflect the committed changes.

epriestley mentioned this in D15100: Fix bad call to getShortName().Jan 24 2016, 1:04 AM

epriestley mentioned this in rPb53d61c90915: Fix bad call to getShortName().Jan 24 2016, 1:07 AM

Revision Contents
Changeset List

Path

Size

src/

applications/

diffusion/

controller/

DiffusionBrowseController.php

2 lines

view/

DiffusionView.php

2 lines

repository/

query/

PhabricatorRepositorySearchEngine.php

14 lines

storage/

PhabricatorRepository.php

19 lines

PhabricatorRepositoryCommit.php

15 lines

Diff 36223

src/applications/diffusion/controller/DiffusionBrowseController.php

Loading...

src/applications/diffusion/view/DiffusionView.php

Loading...

src/applications/repository/query/PhabricatorRepositorySearchEngine.php

Loading...

src/applications/repository/storage/PhabricatorRepository.php

Loading...

src/applications/repository/storage/PhabricatorRepositoryCommit.php

Loading...