Page MenuHomePhabricator

Introduce "local names" for commits
ClosedPublic

Authored by epriestley on Jan 11 2016, 10:52 AM.
Tags
None
Referenced Files
F14059026: D14990.diff
Sun, Nov 17, 4:53 PM
F14045957: D14990.diff
Wed, Nov 13, 4:38 PM
F14043321: D14990.diff
Tue, Nov 12, 9:19 AM
F14037146: D14990.diff
Sun, Nov 10, 2:04 PM
F14021946: D14990.diff
Wed, Nov 6, 2:07 PM
F14008536: D14990.diff
Tue, Oct 29, 11:54 PM
F13997779: D14990.diff
Thu, Oct 24, 6:08 AM
F13987964: D14990.diff
Mon, Oct 21, 12:20 PM
Subscribers
None

Details

Summary

Ref T4245. Full commit display names (like rPaaaa) are going to be obnoxious soon in some cases (e.g., rPaaaa becomes R123:aaaa, which is much uglier) so reduce how often we show the repository in cases where it isn't really necessary to include it.

Test Plan
  • Saw no more rX on repository list view for Git/Mercurial (still present for Subversion).
  • Saw no more rX on various repository detail views, except when referencing other commits (e.g., mentions).
  • Grepped for removed getShortName().

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

epriestley retitled this revision from to Introduce "local names" for commits.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
chad edited edge metadata.
This revision is now accepted and ready to land.Jan 11 2016, 4:57 PM
This revision was automatically updated to reflect the committed changes.