Fix bad call to getShortName()
ClosedPublic
Actions

Authored by epriestley on Jan 24 2016, 1:04 AM.

Tags

None

Referenced Files

	F19089751: D15100.diff
	Wed, Dec 3, 8:27 AM

	F18943261: D15100.id.diff
	Tue, Nov 11, 1:38 PM

	F18932411: D15100.diff
	Mon, Nov 10, 7:30 AM

	F18856253: D15100.id36459.diff
	Nov 1 2025, 8:49 AM

	F18804320: D15100.id36461.diff
	Oct 18 2025, 7:20 AM

	F18761254: D15100.id.diff
	Oct 6 2025, 1:17 PM

	F18755790: D15100.diff
	Oct 5 2025, 7:23 AM

	F18713052: D15100.id.diff
	Sep 29 2025, 5:36 AM

View All Files

Subscribers

None

Details

Reviewers

chad

Maniphest Tasks

T10212: Toggling syntax highlighting in Diffusion causes Unhandled Exception

Commits

Restricted Diffusion Commit
rPb53d61c90915: Fix bad call to getShortName()

Summary

Fixes T10212. This method was removed in D14990, but I missed a callsite.

Test Plan

Disabling blame now works nicely.

Diff Detail

Repository

rP Phabricator

Branch

sname1

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 10297
Build 12539: Run Core Tests
Build 12538: arc lint + arc unit

Event Timeline

epriestley updated this revision to Diff 36459.Jan 24 2016, 1:04 AM

epriestley retitled this revision from to Fix bad call to getShortName().

epriestley updated this object.

epriestley edited the test plan for this revision. (Show Details)

epriestley added a reviewer: chad.

epriestley added a task: T10212: Toggling syntax highlighting in Diffusion causes Unhandled Exception.

chad accepted this revision.Jan 24 2016, 1:06 AM

chad edited edge metadata.

This revision is now accepted and ready to land.Jan 24 2016, 1:06 AM

Closed by commit rPb53d61c90915: Fix bad call to getShortName() (authored by epriestley, committed by epriestley). · Explain WhyJan 24 2016, 1:07 AM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

applications/

diffusion/

controller/

DiffusionBrowseController.php

2 lines

Diff 36459

View Options

src/applications/diffusion/controller/DiffusionBrowseController.php

Fix bad call to getShortName()ClosedPublicActions