Page MenuHomePhabricator

Allow any user to watch any project they can see
ClosedPublic

Authored by epriestley on Jan 20 2016, 1:55 AM.

Details

Summary

Ref T6183. Ref T10054. Historically, only members could watch projects because there were some weird special cases with policies. These policy issues have been resolved and Herald is generally powerful enough to do equivalent watches on most objects anyway.

Also puts a "Watch Project" button on the feed panel to make the behavior and meaning more obvious.

Test Plan
  • Watched a project I was not a member of.
  • Clicked the feed watch/unwatch button.

Diff Detail

Repository
rP Phabricator
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

epriestley updated this revision to Diff 36372.Jan 20 2016, 1:55 AM
epriestley retitled this revision from to Allow any user to watch any project they can see.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
chad accepted this revision.Jan 20 2016, 1:55 AM
chad edited edge metadata.
This revision is now accepted and ready to land.Jan 20 2016, 1:55 AM
epriestley updated this revision to Diff 36373.Jan 20 2016, 2:15 AM
epriestley edited edge metadata.
  • Also allow any user to subscribe to any project they can see.
  • Remove weird rules around removing watches when leaving projects.
This revision was automatically updated to reflect the committed changes.