Page MenuHomePhabricator
Differential D15049

Fix two issues with repository monogram regular expressions
ClosedPublic
Actions

Authored by epriestley on Jan 18 2016, 5:36 PM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Apr 19, 4:07 PM
Unknown Object (File)
Fri, Apr 12, 12:23 PM
Unknown Object (File)
Mon, Apr 8, 2:13 PM
Unknown Object (File)
Tue, Apr 2, 3:12 PM
Unknown Object (File)
Fri, Mar 29, 7:53 PM
Unknown Object (File)
Fri, Mar 29, 1:14 PM
Unknown Object (File)
Mar 5 2024, 9:16 AM
Unknown Object (File)
Mar 5 2024, 9:16 AM
View All Files
Subscribers
None

Details

Reviewers
avivey
chad
Maniphest Tasks
T4245: Make repository URIs slightly prettier
T10172: Commits messages with repository-monogram-like strings are confusing the monogram parser
Commits
Restricted Diffusion Commit
rPba2215986639: (stable) Fix two issues with repository monogram regular expressions
rP155cb1d2c5a8: Fix two issues with repository monogram regular expressions
Summary

Ref T4245. Fixes T10172. These regular expressions were simply incorrect: they intend <start> (form one | form two) <end> but were written as (<start> form one) | (form two <end>) which allowed stuff like "R2/R13" to be interpreted as a monogram because it matches (<start> form one).

Test Plan

Parsed commit ba46ffa6169c from RTEMS repository, see T10172. Before patch, got an identical trace; after patch, clean import.

Diff Detail

Repository
rP Phabricator
Branch
repo1
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 10179
Build 12358: Run Core Tests
Build 12357: arc lint + arc unit

Event Timeline

epriestley updated this revision to Diff 36344.Jan 18 2016, 5:36 PM
epriestley retitled this revision from to Fix two issues with repository monogram regular expressions.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
epriestley added tasks: T10172: Commits messages with repository-monogram-like strings are confusing the monogram parser, T4245: Make repository URIs slightly prettier.
epriestley mentioned this in T10172: Commits messages with repository-monogram-like strings are confusing the monogram parser.Jan 18 2016, 5:37 PM
avivey accepted this revision.Jan 18 2016, 5:46 PM
avivey added a reviewer: avivey.
This revision is now accepted and ready to land.Jan 18 2016, 5:46 PM
Closed by commit rP155cb1d2c5a8: Fix two issues with repository monogram regular expressions (authored by epriestley, committed by epriestley). · Explain WhyJan 18 2016, 5:46 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
src/
applications/
repository/
phid/
2 lines
query/
2 lines

Diff 36344

View Options

src/applications/repository/phid/PhabricatorRepositoryRepositoryPHIDType.php

Loading...
View Options

src/applications/repository/query/PhabricatorRepositoryQuery.php

Loading...
Phabricator · Built by Phacility