Paths

Table of Contentst

Differential D15049

Fix two issues with repository monogram regular expressions
ClosedPublic
Actions

Authored by epriestley on Jan 18 2016, 5:36 PM.

Tags

None

Referenced Files

	F15394421: D15049.id36345.diff
	Sat, Mar 15, 11:51 PM

	F15394419: D15049.id36344.diff
	Sat, Mar 15, 11:51 PM

	F15394418: D15049.id.diff
	Sat, Mar 15, 11:51 PM

	F15394416: D15049.diff
	Sat, Mar 15, 11:51 PM

	F15386739: D15049.id.diff
	Sat, Mar 15, 1:13 AM

	F15374656: D15049.id36345.diff
	Wed, Mar 12, 8:15 PM

	F15374655: D15049.id36344.diff
	Wed, Mar 12, 8:15 PM

	F15374654: D15049.id.diff
	Wed, Mar 12, 8:15 PM

Subscribers

None

Details

Reviewers

avivey
chad

Maniphest Tasks

T4245: Make repository URIs slightly prettier
T10172: Commits messages with repository-monogram-like strings are confusing the monogram parser

Commits

Restricted Diffusion Commit
rPba2215986639: (stable) Fix two issues with repository monogram regular expressions
rP155cb1d2c5a8: Fix two issues with repository monogram regular expressions

Summary

Ref T4245. Fixes T10172. These regular expressions were simply incorrect: they intend <start> (form one | form two) <end> but were written as (<start> form one) | (form two <end>) which allowed stuff like "R2/R13" to be interpreted as a monogram because it matches (<start> form one).

Test Plan

Parsed commit ba46ffa6169c from RTEMS repository, see T10172. Before patch, got an identical trace; after patch, clean import.

Diff Detail

Repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

epriestley updated this revision to Diff 36344.Jan 18 2016, 5:36 PM

epriestley retitled this revision from to Fix two issues with repository monogram regular expressions.

epriestley updated this object.

epriestley edited the test plan for this revision. (Show Details)

epriestley added a reviewer: chad.

epriestley added tasks: T10172: Commits messages with repository-monogram-like strings are confusing the monogram parser, T4245: Make repository URIs slightly prettier.

epriestley mentioned this in T10172: Commits messages with repository-monogram-like strings are confusing the monogram parser.Jan 18 2016, 5:37 PM

avivey accepted this revision.Jan 18 2016, 5:46 PM

avivey added a reviewer: avivey.

This revision is now accepted and ready to land.Jan 18 2016, 5:46 PM

Closed by commit rP155cb1d2c5a8: Fix two issues with repository monogram regular expressions (authored by epriestley, committed by epriestley). · Explain WhyJan 18 2016, 5:46 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

applications/

repository/

phid/

PhabricatorRepositoryRepositoryPHIDType.php

2 lines

query/

PhabricatorRepositoryQuery.php

2 lines

Diff 36345

src/applications/repository/phid/PhabricatorRepositoryRepositoryPHIDType.php

Loading...

src/applications/repository/query/PhabricatorRepositoryQuery.php

Loading...