Page MenuHomePhabricator

Fix two issues with repository monogram regular expressions
ClosedPublic

Authored by epriestley on Jan 18 2016, 5:36 PM.

Details

Summary

Ref T4245. Fixes T10172. These regular expressions were simply incorrect: they intend <start> (form one | form two) <end> but were written as (<start> form one) | (form two <end>) which allowed stuff like "R2/R13" to be interpreted as a monogram because it matches (<start> form one).

Test Plan

Parsed commit ba46ffa6169c from RTEMS repository, see T10172. Before patch, got an identical trace; after patch, clean import.

Diff Detail

Repository
rP Phabricator
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

epriestley updated this revision to Diff 36344.Jan 18 2016, 5:36 PM
epriestley retitled this revision from to Fix two issues with repository monogram regular expressions.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
avivey accepted this revision.Jan 18 2016, 5:46 PM
avivey added a reviewer: avivey.
This revision is now accepted and ready to land.Jan 18 2016, 5:46 PM
This revision was automatically updated to reflect the committed changes.