Differential D15044

Distinguish between "no coverage information" and "no test coverage" better
ClosedPublic
Actions

Authored by epriestley on Jan 18 2016, 3:11 PM.

Details

Reviewers

chad

Maniphest Tasks

T10169: Differential Revision without coverage shows all code as "Non Executable"

Commits

Restricted Diffusion Commit
rP45a4a68628b9: Distinguish between "no coverage information" and "no test coverage" better

Summary

Fixes T10169. Diffs with no build targets were incorrectly showing as though they had no test coverage, when we actually want to show them having no coverage information available.

Test Plan

Viewed an older revision, saw a column of "Not Executable" before change, now see no column.

Diff Detail

Repository

rP Phabricator

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

epriestley updated this revision to Diff 36332.Jan 18 2016, 3:11 PM

epriestley retitled this revision from to Distinguish between "no coverage information" and "no test coverage" better.

epriestley updated this object.

epriestley edited the test plan for this revision. (Show Details)

epriestley added a reviewer: chad.

epriestley added a task: T10169: Differential Revision without coverage shows all code as "Non Executable".

chad accepted this revision.Jan 18 2016, 3:50 PM

chad edited edge metadata.

This revision is now accepted and ready to land.Jan 18 2016, 3:50 PM

Closed by commit rP45a4a68628b9: Distinguish between "no coverage information" and "no test coverage" better (authored by epriestley, committed by epriestley). · Explain WhyJan 18 2016, 4:34 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

applications/

differential/

controller/

DifferentialChangesetViewController.php

15 lines

Diff 36336

View Options

src/applications/differential/controller/DifferentialChangesetViewController.php

Distinguish between "no coverage information" and "no test coverage" betterClosedPublicActions