Differential D15030

Cleans up some minor issues in cpplint
ClosedPublic
Actions

Authored by michaeloa on Jan 15 2016, 3:50 PM.

Details

Reviewers

epriestley

Group Reviewers

Blessed Reviewers

Maniphest Tasks

T10157: Cleaning up arcanist cpplint

Commits

rARC2412c31346ad: (stable) Promote 2016 Week 3
rARCb87138356a9c: Cleans up some minor issues in cpplint

Summary

Corrected typo in install instructions
Sets the default binary to cpplint.py

Test Plan

Running the unit tests.

You may need to check your test environment is set up with the latest
cpplint.py available, since the default binary is being changed.

Diff Detail

Repository

rARC Arcanist

Branch

T10157 (branched from master)

Lint

Lint Passed

Unit

Tests Skipped

Build Status

Buildable 10128
Build 12287: arc lint + arc unit

Event Timeline

michaeloa updated this revision to Diff 36296.Jan 15 2016, 3:50 PM

michaeloa added a task: T10157: Cleaning up arcanist cpplint.

michaeloa retitled this revision from to Cleans up some minor issues in cpplint.

michaeloa updated this object.

michaeloa edited the test plan for this revision. (Show Details)

michaeloa added a reviewer: epriestley.

Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptJan 15 2016, 3:50 PM

Herald added a subscriber: Korvin. · View Herald Transcript

epriestley accepted this revision.Jan 15 2016, 4:19 PM

epriestley edited edge metadata.

This revision is now accepted and ready to land.Jan 15 2016, 4:19 PM

Closed by commit rARCb87138356a9c: Cleans up some minor issues in cpplint (authored by michaeloa, committed by epriestley). · Explain WhyJan 15 2016, 4:19 PM

This revision was automatically updated to reflect the committed changes.

epriestley mentioned this in T10157: Cleaning up arcanist cpplint.Jan 18 2016, 2:53 PM

Revision Contents
Changeset List

Path

Size

src/

lint/

linter/

ArcanistCpplintLinter.php

4 lines

Diff 36296

View Options

src/lint/linter/ArcanistCpplintLinter.php

Cleans up some minor issues in cpplintClosedPublicActions