HomePhabricator

Minor fixes to arcanist cpplint

Description

Minor fixes to arcanist cpplint

Summary:
This fixes the regex in "getLintCode..." so that it accepts lint
codes such as build/c++11 which have become valid lint codes
in later versions of cpplint.

It also corrects the install instructions for the linter (Google's
style guide is no longer available on SVN and has been migrated to
Github).

Test Plan:
For the Regex:

  • Create an .arclint in a project such as:
{
  "linters": {
    "cpplint": {
      "type": "cpplint",
      "severity": {
        "build/c++11": "advice"
      }
    }
  }
}
  • Run arc lint with the existing linter. This should fail. Patch the linter, and this should now be accepted.

For the Instructions

  • Verify the download location wget https://raw.github.com/google/styleguide/gh-pages/cpplint/cpplint.py

Reviewers: epriestley, Blessed Reviewers

Reviewed By: epriestley, Blessed Reviewers

Subscribers: Korvin

Maniphest Tasks: T10118

Differential Revision: https://secure.phabricator.com/D15019

Details

Provenance
michaeloaAuthored on Jan 14 2016, 2:59 PM
epriestleyCommitted on Jan 14 2016, 2:59 PM
epriestleyPushed on Jan 14 2016, 2:59 PM
Reviewer
Blessed Reviewers
Differential Revision
D15019: Minor fixes to arcanist cpplint
Parents
rARC05c12eb9d9cb: If the Script-and-Regex linter captures no "line" text, treat the message as…
Branches
Unknown
Tags
Unknown
Build Status
Buildable 10108
Build 12252: Run Core Tests