Differential D14991

Support synthetic submits from stacked actions
ClosedPublic
Actions

Authored by epriestley on Jan 11 2016, 11:01 AM.

Details

Reviewers

chad

Maniphest Tasks

T10116: ctrl+enter in comment field in maniphest issues with new editor

Commits

Restricted Diffusion Commit
rP5a723bff9177: Support synthetic submits from stacked actions

Summary

Fixes T10116.

Test Plan

Prior to patch: Control/Command + Enter submitted form but ignored actions.
After patch: verifid command + enter submits actions.

Diff Detail

Repository

rP Phabricator

Branch

synthetic1

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 10046
Build 12156: Run Core Tests
Build 12155: arc lint + arc unit

Event Timeline

epriestley updated this revision to Diff 36212.Jan 11 2016, 11:01 AM

epriestley retitled this revision from to Support synthetic submits from stacked actions.

epriestley updated this object.

epriestley edited the test plan for this revision. (Show Details)

epriestley added a reviewer: chad.

epriestley added a task: T10116: ctrl+enter in comment field in maniphest issues with new editor.

chad accepted this revision.Jan 11 2016, 5:16 PM

chad edited edge metadata.

This revision is now accepted and ready to land.Jan 11 2016, 5:16 PM

Closed by commit rP5a723bff9177: Support synthetic submits from stacked actions (authored by epriestley, committed by epriestley). · Explain WhyJan 11 2016, 5:16 PM

This revision was automatically updated to reflect the committed changes.

epriestley mentioned this in T10263: Using Cmd+Enter on "Add Actions" results in actions not being applied.Feb 2 2016, 3:12 PM

Revision Contents
Changeset List

Path

Size

resources/

celerity/

map.php

22 lines

webroot/

rsrc/

js/

application/

transactions/

behavior-comment-actions.js

3 lines

Diff 36212

View Options

resources/celerity/map.php