Page MenuHomePhabricator
Differential D14936

Convert passphrase to edit engine
AbandonedPublic
Actions

Authored by joshuaspence on Jan 4 2016, 12:37 PM.
Tags
None
Referenced Files
F15516751: D14936.diff
Fri, Apr 18, 9:03 PM
F15514277: D14936.id36079.diff
Fri, Apr 18, 1:20 AM
F15513918: D14936.id36089.diff
Thu, Apr 17, 10:52 PM
F15513394: D14936.id.diff
Thu, Apr 17, 6:43 PM
F15509389: D14936.diff
Wed, Apr 16, 12:03 PM
F15504725: D14936.diff
Mon, Apr 14, 8:01 PM
F15491205: D14936.id36079.diff
Sat, Apr 12, 12:09 AM
F15464258: D14936.id36089.diff
Wed, Apr 2, 7:52 AM
View All Files
Subscribers
Korvin
Krenair

Details

Reviewers
epriestley
Group Reviewers
Blessed Reviewers
Summary

This doesn't quite work yet, but is a start...

Test Plan

WIP

Diff Detail

Repository
rP Phabricator
Branch
master
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 9913
Build 11960: Run Core Tests
Build 11959: arc lint + arc unit

Event Timeline

joshuaspence updated this revision to Diff 36079.Jan 4 2016, 12:37 PM
joshuaspence retitled this revision from to Convert passphrase to edit engine.
joshuaspence updated this object.
joshuaspence edited the test plan for this revision. (Show Details)
joshuaspence added a reviewer: epriestley.
Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptJan 4 2016, 12:37 PM
Herald added a subscriber: Korvin. · View Herald Transcript
joshuaspence updated this revision to Diff 36089.Jan 4 2016, 8:24 PM
joshuaspence edited edge metadata.

Further progress

Krenair added a subscriber: Krenair.Nov 16 2017, 10:19 PM
joshuaspence abandoned this revision.May 17 2019, 1:52 AM

Not actively working on this.

Revision Contents
Changeset List

PathSizeCoverage (All)Coverage (Touched)
src/
10 lines--
applications/
passphrase/
conduit/
19 lines66%
Loading...
18 lines80%
Loading...
controller/
374 lines33%
Loading...
credentialtype/
4 lines19%
Loading...
4 lines33%
Loading...
5 lines37%
Loading...
4 lines33%
Loading...
editor/
123 lines4%
Loading...
storage/
4 lines2%
Loading...
transactions/
editengine/
1 line0%
Loading...
editfield/
14 lines50%
Loading...
15 lines40%
Loading...

Diff 36089

View Options

src/__phutil_library_map__.php

Loading...
View Options

src/applications/passphrase/conduit/PassphraseEditConduitAPIMethod.php

Loading...
View Options

src/applications/passphrase/conduit/PassphraseSearchConduitAPIMethod.php

Loading...
View Options

src/applications/passphrase/controller/PassphraseCredentialEditController.php

Loading...
View Options

src/applications/passphrase/credentialtype/PassphraseCredentialType.php

Loading...
View Options

src/applications/passphrase/credentialtype/PassphraseNoteCredentialType.php

Loading...
View Options

src/applications/passphrase/credentialtype/PassphrasePasswordCredentialType.php

Loading...
View Options

src/applications/passphrase/credentialtype/PassphraseSSHPrivateKeyFileCredentialType.php

Loading...
View Options

src/applications/passphrase/editor/PassphraseCredentialEditEngine.php

Loading...
View Options

src/applications/passphrase/storage/PassphraseCredential.php

Loading...
View Options

src/applications/transactions/editengine/PhabricatorEditEngine.php

Loading...
View Options

src/applications/transactions/editfield/PhabricatorBooleanEditField.php

Loading...
View Options

src/applications/transactions/editfield/PhabricatorPasswordEditField.php

Loading...
Phabricator · Built by Phacility