Page MenuHomePhabricator
Differential D14926

Remove calls to getCallsign() from repository daemons
ClosedPublic
Actions

Authored by epriestley on Jan 2 2016, 1:55 PM.
Tags
None
Referenced Files
Unknown Object (File)
Mon, Dec 9, 5:42 PM
Unknown Object (File)
Mon, Dec 9, 12:15 PM
Unknown Object (File)
Sat, Dec 7, 1:19 AM
Unknown Object (File)
Thu, Dec 5, 5:32 PM
Unknown Object (File)
Tue, Dec 3, 1:05 PM
Unknown Object (File)
Thu, Nov 28, 3:50 PM
Unknown Object (File)
Thu, Nov 28, 2:24 AM
Unknown Object (File)
Sun, Nov 24, 2:27 AM
View All Files
Subscribers
None

Details

Reviewers
chad
Maniphest Tasks
T4245: Make repository URIs slightly prettier
Commits
Restricted Diffusion Commit
rPd9e034f02ca0: Remove calls to getCallsign() from repository daemons
Summary

Ref T4245. These are all descriptive or UI-facing.

Test Plan
  • Ran bin/repository pull ... with various identifiers.
  • Ran bin/repository mirror ... with various identifiers.
  • Ran bin/repository discover ... with various identifiers.
  • Ran bin/phd debug pull X Y --not Z with various identifiers.

Diff Detail

Repository
rP Phabricator
Branch
callsign3
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 9889
Build 11922: Run Core Tests
Build 11921: arc lint + arc unit

Event Timeline

epriestley updated this revision to Diff 36065.Jan 2 2016, 1:55 PM
epriestley retitled this revision from to Remove calls to getCallsign() from repository daemons.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
epriestley added a task: T4245: Make repository URIs slightly prettier.
chad accepted this revision.Jan 2 2016, 4:11 PM
chad edited edge metadata.
This revision is now accepted and ready to land.Jan 2 2016, 4:11 PM
Closed by commit rPd9e034f02ca0: Remove calls to getCallsign() from repository daemons (authored by epriestley, committed by epriestley). · Explain WhyJan 2 2016, 7:03 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 36065

View Options

src/applications/repository/daemon/PhabricatorRepositoryPullLocalDaemon.php

Loading...
View Options

src/applications/repository/engine/PhabricatorRepositoryDiscoveryEngine.php

Loading...
View Options

src/applications/repository/engine/PhabricatorRepositoryMirrorEngine.php

Loading...
View Options

src/applications/repository/engine/PhabricatorRepositoryPullEngine.php

Loading...
Phabricator · Built by Phacility