Page MenuHomePhabricator
Differential D14926

Remove calls to getCallsign() from repository daemons
ClosedPublic
Actions

Authored by epriestley on Jan 2 2016, 1:55 PM.
Tags
None
Referenced Files
F19505454: D14926.id.diff
Fri, Jan 9, 11:45 AM
F19087335: D14926.id36068.diff
Dec 3 2025, 12:18 AM
F19087333: D14926.id36065.diff
Dec 3 2025, 12:18 AM
F19087332: D14926.id.diff
Dec 3 2025, 12:17 AM
F19080233: D14926.diff
Dec 2 2025, 12:24 AM
F19041068: D14926.id.diff
Nov 26 2025, 2:28 PM
F19035000: D14926.diff
Nov 25 2025, 3:51 PM
F18835309: D14926.id.diff
Oct 26 2025, 2:55 PM
View All Files
Subscribers
None

Details

Reviewers
chad
Maniphest Tasks
T4245: Make repository URIs slightly prettier
Commits
Restricted Diffusion Commit
rPd9e034f02ca0: Remove calls to getCallsign() from repository daemons
Summary

Ref T4245. These are all descriptive or UI-facing.

Test Plan
  • Ran bin/repository pull ... with various identifiers.
  • Ran bin/repository mirror ... with various identifiers.
  • Ran bin/repository discover ... with various identifiers.
  • Ran bin/phd debug pull X Y --not Z with various identifiers.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

epriestley updated this revision to Diff 36065.Jan 2 2016, 1:55 PM
epriestley retitled this revision from to Remove calls to getCallsign() from repository daemons.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
epriestley added a task: T4245: Make repository URIs slightly prettier.
chad accepted this revision.Jan 2 2016, 4:11 PM
chad edited edge metadata.
This revision is now accepted and ready to land.Jan 2 2016, 4:11 PM
Closed by commit rPd9e034f02ca0: Remove calls to getCallsign() from repository daemons (authored by epriestley, committed by epriestley). · Explain WhyJan 2 2016, 7:03 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 36068

View Options

src/applications/repository/daemon/PhabricatorRepositoryPullLocalDaemon.php

Loading...
View Options

src/applications/repository/engine/PhabricatorRepositoryDiscoveryEngine.php

Loading...
View Options

src/applications/repository/engine/PhabricatorRepositoryMirrorEngine.php

Loading...
View Options

src/applications/repository/engine/PhabricatorRepositoryPullEngine.php

Loading...
Phabricator · Built by Phacility