Page MenuHomePhabricator

Give custom controls passable disabled states
ClosedPublic

Authored by epriestley on Dec 17 2015, 9:32 PM.

Details

Summary

Fixes T9871. Ref T10004. These won't win any awards but it fixes them being incredibly weird and confusing.

Test Plan

Screen Shot 2015-12-17 at 1.30.37 PM.png (961×1 px, 83 KB)

  • Tried to use controls, got reasonable behavior.
  • Used normal controls to make sure I didn't break anything.

Diff Detail

Repository
rP Phabricator
Branch
ae11
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 9632
Build 11531: Run Core Tests
Build 11530: arc lint + arc unit

Event Timeline

Tokenizers aren't showing default values correctly so I probably need to do that one a little less badly.

epriestley edited edge metadata.
  • Cleaner patch.
  • Fewer debug logs.
  • Less bad behavior.
chad edited edge metadata.
This revision is now accepted and ready to land.Dec 17 2015, 11:12 PM
This revision was automatically updated to reflect the committed changes.