Page MenuHomePhabricator
Differential D14814

Give custom controls passable disabled states
ClosedPublic
Actions

Authored by epriestley on Dec 17 2015, 9:32 PM.
Tags
None
Referenced Files
F14053469: D14814.diff
Fri, Nov 15, 4:00 PM
F14050488: D14814.diff
Thu, Nov 14, 6:52 PM
F14038347: D14814.diff
Sun, Nov 10, 11:05 PM
F14036123: D14814.id35817.diff
Sun, Nov 10, 8:36 AM
F14024125: D14814.id35814.diff
Thu, Nov 7, 6:13 AM
F14022733: D14814.diff
Wed, Nov 6, 7:06 PM
F13992743: D14814.id35817.diff
Tue, Oct 22, 6:32 PM
F13992260: D14814.diff
Tue, Oct 22, 3:30 PM
View All Files
Subscribers
None

Details

Reviewers
chad
Maniphest Tasks
T9871: Some PHUI form controls do not have identifiable "disabled" states
T10004: ApplicationEditor Errata
Commits
Restricted Diffusion Commit
rPa07a06ab0895: Give custom controls passable disabled states
Summary

Fixes T9871. Ref T10004. These won't win any awards but it fixes them being incredibly weird and confusing.

Test Plan

Screen Shot 2015-12-17 at 1.30.37 PM.png (961×1 px, 83 KB)

  • Tried to use controls, got reasonable behavior.
  • Used normal controls to make sure I didn't break anything.

Diff Detail

Repository
rP Phabricator
Branch
ae11
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 9632
Build 11531: Run Core Tests
Build 11530: arc lint + arc unit

Event Timeline

Herald edited edge metadata. · View Herald TranscriptDec 17 2015, 9:32 PM
epriestley planned changes to this revision.Dec 17 2015, 9:32 PM

Tokenizers aren't showing default values correctly so I probably need to do that one a little less badly.

epriestley updated this revision to Diff 35815.Dec 17 2015, 9:36 PM
epriestley edited edge metadata.
  • Cleaner patch.
  • Fewer debug logs.
  • Less bad behavior.
Herald edited edge metadata. · View Herald TranscriptDec 17 2015, 9:36 PM
chad accepted this revision.Dec 17 2015, 11:12 PM
chad edited edge metadata.
This revision is now accepted and ready to land.Dec 17 2015, 11:12 PM
Closed by commit rPa07a06ab0895: Give custom controls passable disabled states (authored by epriestley, committed by epriestley). · Explain WhyDec 17 2015, 11:13 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
resources/
celerity/
94 lines
src/
view/
form/
control/
2 lines
1 line
28 lines
webroot/
rsrc/
css/
phui/
4 lines
externals/
javelin/
lib/
control/
tokenizer/
8 lines
js/
application/
policy/
8 lines
core/
4 lines
4 lines

Diff 35815

View Options

resources/celerity/map.php

Loading...
View Options

src/view/form/control/AphrontFormPolicyControl.php

Loading...
View Options

src/view/form/control/AphrontFormTokenizerControl.php

Loading...
View Options

src/view/form/control/PhabricatorRemarkupControl.php

Loading...
View Options

webroot/rsrc/css/phui/phui-form.css

Loading...
View Options

webroot/rsrc/externals/javelin/lib/control/tokenizer/Tokenizer.js

Loading...
View Options

webroot/rsrc/js/application/policy/behavior-policy-control.js

Loading...
View Options

webroot/rsrc/js/core/Prefab.js

Loading...
View Options

webroot/rsrc/js/core/behavior-phabricator-remarkup-assist.js

Loading...
Phabricator · Built by Phacility