Differential D14759

Simplify diff exit code handling.
ClosedPublic
Actions

Authored by dim on Dec 13 2015, 10:34 AM.

Details

Reviewers

epriestley

Group Reviewers

Blessed Reviewers

Maniphest Tasks

T9970: new files are empty for arc diff --create and --update

Commits

rARC7d25fcdbdb51: Simplify diff exit code handling.

Summary

This fixes T9970 in an alternate manner, with the same effect: the
binary_safe_diff.sh script returns 0 if the diff succeeds, 1 in all
other cases.

Test Plan

Tested locally with a fixed binary_safe_diff.sh, resulting in this
correct review:

https://reviews.freebsd.org/D4542

Diff Detail

Repository

rARC Arcanist

Branch

fix-t9970-alt

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 9509
Build 11340: arc lint + arc unit

Event Timeline

dim updated this revision to Diff 35691.Dec 13 2015, 10:34 AM

dim retitled this revision from to Simplify diff exit code handling..

dim updated this object.

dim edited the test plan for this revision. (Show Details)

dim added a reviewer: epriestley.

dim added a task: T9970: new files are empty for arc diff --create and --update .

dim added subscribers: • stevenh, eadler.

Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptDec 13 2015, 10:34 AM

Herald added a subscriber: Korvin. · View Herald Transcript

Thanks!

This revision is now accepted and ready to land.Dec 13 2015, 10:34 AM

dim mentioned this in D14755: Preserve the exit code of the diff command in binary_safe_diff.sh.Dec 13 2015, 10:35 AM

Closed by commit rARC7d25fcdbdb51: Simplify diff exit code handling. (authored by dim, committed by epriestley). · Explain WhyDec 13 2015, 10:35 AM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

scripts/

repository/

binary_safe_diff.sh

7 lines

Diff 35691

View Options

scripts/repository/binary_safe_diff.sh

Simplify diff exit code handling.ClosedPublicActions