Page MenuHomePhabricator

Add proper PHIDs to RefCursors
ClosedPublic

Authored by epriestley on Dec 10 2015, 9:08 PM.
Tags
None
Referenced Files
F15471051: D14731.id35631.diff
Sat, Apr 5, 3:01 AM
F15456853: D14731.id35631.diff
Sun, Mar 30, 12:38 PM
F15449363: D14731.id35631.diff
Fri, Mar 28, 9:42 AM
F15440189: D14731.id35631.diff
Wed, Mar 26, 11:20 AM
F15436685: D14731.diff
Tue, Mar 25, 3:51 PM
F15436223: D14731.id35624.diff
Tue, Mar 25, 12:44 PM
F15435572: D14731.id.diff
Tue, Mar 25, 8:57 AM
F15432238: D14731.diff
Mon, Mar 24, 4:58 PM
Subscribers
None

Details

Summary

Ref T9952. See discussion there. This change is primarily aimed at letting me build a typeahead of branches in a repository so that we can land to arbitrary branches a few diffs from now.

Test Plan
  • Ran migrations.
  • Verified database populated properly with PHIDs (SELECT * FROM repository_refcursor;).
  • Ran bin/repository update.
  • Viewed a Git repository in Diffusion.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

epriestley retitled this revision from to Add proper PHIDs to RefCursors.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
src/applications/repository/storage/PhabricatorRepositoryRefCursor.php
35–37

This was intentionally nullable, null means "we don't know the encoding". I just didn't remember this when I was doing the storage adjust stuff.

chad edited edge metadata.
This revision is now accepted and ready to land.Dec 10 2015, 9:14 PM
This revision was automatically updated to reflect the committed changes.