Differential D14683

Add a "Change priority to: ..." Herald action
ClosedPublic
Actions

Authored by epriestley on Dec 5 2015, 7:17 PM.

Details

Reviewers

chad

Maniphest Tasks

T7848: Allow herald rules to change task status in HeraldManiphestTaskAdapter Actions

Commits

Restricted Diffusion Commit
rPf22dc9d47a5d: Add a "Change priority to: ..." Herald action

Summary

Ref T7848. This is a companion to "Change status to: ...".

(I'm pretty sure the only reason I didn't originally write these was the tokenizer bug in D14682, I just forgot about it).

This is basically a copy/paste of the "status" action.

Test Plan

Wrote a rule to change task priorities.
Edited a task.
Saw rule fire properly.
Tokens also stick around correctly.

Diff Detail

Repository

rP Phabricator

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

epriestley updated this revision to Diff 35511.Dec 5 2015, 7:17 PM

epriestley retitled this revision from to Add a "Change priority to: ..." Herald action.

epriestley updated this object.

epriestley edited the test plan for this revision. (Show Details)

epriestley added a reviewer: chad.

epriestley added a task: T7848: Allow herald rules to change task status in HeraldManiphestTaskAdapter Actions.

chad accepted this revision.Dec 5 2015, 7:19 PM

chad edited edge metadata.

This revision is now accepted and ready to land.Dec 5 2015, 7:19 PM

Closed by commit rPf22dc9d47a5d: Add a "Change priority to: ..." Herald action (authored by epriestley, committed by epriestley). · Explain WhyDec 5 2015, 7:20 PM

This revision was automatically updated to reflect the committed changes.

epriestley mentioned this in T10003: Upgrading: Maniphest field-level policies ("Can Prioritize Tasks", etc.) have been deprecated and will be removed.Dec 16 2015, 6:27 PM

Revision Contents
Changeset List

Path

Size

src/

__phutil_library_map__.php

2 lines

applications/

maniphest/

herald/

ManiphestTaskPriorityHeraldAction.php

87 lines

Diff 35513

View Options

src/__phutil_library_map__.php